Skip to content

async can't read binary data #138

Description

@chrysn

Trying albumart() on async fails because _execute_binary is not implemented in async.

Adding it is not just as easy as it sounds because of how the async version is implemented (that is, by reading all lines and dispatching them to the current command; the 'reading the lines' part is what causes the trouble).

As due to the recently increased minimum version a few new idioms have become usable (and the async ecosystem has generally evolved in the last years), I consider rewriting a few parts around this in a way that would trivially solve the binary-data issue.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions