Repository navigation
fix: Mirror setTimeout endowment in setInterval - #4127
Merged
Merged
Conversation
Mrtenz
approved these changes
Sep 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4127 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 429 429
Lines 12509 12511 +2
Branches 1978 1978
=======================================
+ Hits 12334 12336 +2
Misses 175 175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror
setTimeoutendowment insetInterval.Note
Low Risk
Small parity fix in the Snap timer endowment that matches an existing setTimeout pattern; no new APIs or auth/data paths.
Overview
The attenuated
setIntervalendowment no longer registers the Snap’s callback directly with the platform timer. It now uses the same wrapper assetTimeout: a small arrow function that forwards...passedArgsinto the hardened handler.This keeps interval ticks consistent with timeout callbacks in the execution environment (invocation path and hardened-function behavior) without changing validation, handle registration, or
clearIntervalsemantics.Reviewed by Cursor Bugbot for commit ab2b91a. Bugbot is set up for automated code reviews on this repo. Configure here.