Repository navigation
fix: Sync PrivateKeyEncoding type and struct - #4104
Merged
Merged
Conversation
FrederikBolding
marked this pull request as ready for review
August 26, 2026 09:55
FrederikBolding
enabled auto-merge
August 26, 2026 09:55
Mrtenz
approved these changes
Aug 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4104 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 429 429
Lines 12495 12495
Branches 1976 1976
=======================================
Hits 12320 12320
Misses 175 175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync
PrivateKeyEncodingtype and struct withkeyring-api. It was out of sync causing issues for certain Snaps.Note
Low Risk
Narrow type and validation allowlist expansion aligned with keyring-api; no auth or data-path changes.
Overview
Adds
base32as a supported private-key encoding in the Snaps SDK and utils so they match@metamask/keyring-api.The
PrivateKeyEncodingunion inpermissions.tsand thePrivateKeyEncodingStructenum used byendowment:keyringcapabilities validation inkeyring.tspreviously only allowedhexadecimalandbase58. Snaps that declarebase32in import/export format capabilities were failing type or runtime checks until this sync.Reviewed by Cursor Bugbot for commit 05c94ac. Bugbot is set up for automated code reviews on this repo. Configure here.