Repository navigation
feat: block AccountTreeController messenger calls - #4100
Merged
Merged
Conversation
FrederikBolding
approved these changes
Aug 14, 2026
FrederikBolding
enabled auto-merge
August 14, 2026 13:26
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4100 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 429 429
Lines 12495 12495
Branches 1976 1976
=======================================
Hits 12320 12320
Misses 175 175 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll soon introduce some export/import feature on the
AccountTreeController, so it's best if we block it from messenger calls for now.Note
Low Risk
Single-line addition to an existing Snap RPC denylist; tightens access rather than widening it.
Overview
AccountTreeControlleris added to the denylist used bysnap_messengerCall, so preinstalled Snaps can no longer dispatch messenger actions whose names start with that client (same pattern as other blocked controllers).This is a proactive lockdown ahead of planned account-tree export/import work, reducing the chance Snaps reach that surface before it is intentionally exposed.
Reviewed by Cursor Bugbot for commit aa86561. Bugbot is set up for automated code reviews on this repo. Configure here.