Skip to content

feat: block AccountTreeController messenger calls - #4100

Merged
FrederikBolding merged 1 commit into
mainfrom
cc/feat/blocking-account-tree-controller
Aug 14, 2026
Merged

FrederikBolding merged 1 commit into
mainfrom
cc/feat/blocking-account-tree-controller

Conversation

@ccharly

@ccharly ccharly commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

We'll soon introduce some export/import feature on the AccountTreeController, so it's best if we block it from messenger calls for now.


Note

Low Risk
Single-line addition to an existing Snap RPC denylist; tightens access rather than widening it.

Overview
AccountTreeController is added to the denylist used by snap_messengerCall, so preinstalled Snaps can no longer dispatch messenger actions whose names start with that client (same pattern as other blocked controllers).

This is a proactive lockdown ahead of planned account-tree export/import work, reducing the chance Snaps reach that surface before it is intentionally exposed.

Reviewed by Cursor Bugbot for commit aa86561. Bugbot is set up for automated code reviews on this repo. Configure here.

@ccharly
ccharly requested a review from a team as a code owner August 14, 2026 13:21
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (14eeb53) to head (aa86561).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4100   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         429      429           
  Lines       12495    12495           
  Branches     1976     1976           
=======================================
  Hits        12320    12320           
  Misses        175      175           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding
FrederikBolding added this pull request to the merge queue Aug 14, 2026
Merged via the queue into main with commit 7818c72 Aug 14, 2026
132 checks passed
@FrederikBolding
FrederikBolding deleted the cc/feat/blocking-account-tree-controller branch August 14, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants