fix: Properly catch cronjob errors during initialization - #3373
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3373 +/- ##
==========================================
+ Coverage 98.03% 98.06% +0.02%
==========================================
Files 397 397
Lines 10899 10898 -1
Branches 1714 1714
==========================================
+ Hits 10685 10687 +2
+ Misses 214 211 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FrederikBolding
marked this pull request as ready for review
May 5, 2025 10:25
FrederikBolding
enabled auto-merge
May 5, 2025 10:25
david0xd
approved these changes
May 5, 2025
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
Firstly, we were not catching errors thrown during the "daily checkin" of the
CronjobController, this means that if one Snap failed we would not complete the initialization of the controller and no cronjobs would run.Secondly, we were running all the cronjobs sequentially during "daily check" which seems unintentional given that we don't need the result of the cronjob invocation.