Skip to content
This repository was archived by the owner on Jun 16, 2026. It is now read-only.

meta: Drop nodejs v16 support - #277

Merged
legobeat merged 3 commits into
MetaMask:mainfrom
legobeat:meta-node-18
Mar 20, 2024
Merged

meta: Drop nodejs v16 support#277
legobeat merged 3 commits into
MetaMask:mainfrom
legobeat:meta-node-18

Conversation

@legobeat

@legobeat legobeat commented Feb 22, 2024

Copy link
Copy Markdown
Contributor
  • Change instructions in README.md to installing node v18 instead of node v16
  • Bump devDependency @types/node from ^16.18.31 to ^18.19.17

Related

@legobeat
legobeat requested review from a team, kanthesha and mikesposito February 22, 2024 09:34
@socket-security

socket-security Bot commented Feb 22, 2024 •
edited
Loading

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/node@18.19.25 None 0 0 B
npm/undici-types@5.26.5 None 0 73.1 kB ethan_arrowood

🚮 Removed packages: npm/@types/node@16.18.90

View full report↗︎

mcmire
mcmire reviewed Mar 18, 2024
View reviewed changes
Comment thread README.md Outdated
@legobeat @mcmire
Update README.md
5f7fce0 
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@mcmire

mcmire commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

We'll have to include this in another release.

@legobeat

legobeat commented Mar 19, 2024

Copy link
Copy Markdown
Contributor Author

We'll have to include this in another release.

?

@mcmire

mcmire commented Mar 20, 2024

Copy link
Copy Markdown
Contributor

Oh, right, this can just be merged - it doesn't require releasing, yes?

@legobeat

legobeat commented Mar 20, 2024

Copy link
Copy Markdown
Contributor Author

Oh, right, this can just be merged - it doesn't require releasing, yes?
Not sure I understand the question but it shouldn't trigger need for new release on its iwn if that's what you mean. Any reason to hold it back..?

@mcmire

mcmire commented Mar 20, 2024

Copy link
Copy Markdown
Contributor

@legobeat No, we don't need to hold this back. Sorry, I was just confused, ignore me :)

@legobeat
legobeat merged commit 74b2555 into MetaMask:main Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mikesposito mikesposito Awaiting requested review from mikesposito
@kanthesha kanthesha Awaiting requested review from kanthesha
@dan437 dan437 Awaiting requested review from dan437
2 more reviewers
@mcmire mcmire mcmire approved these changes
@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legobeat @mcmire @pedronfigueiredo