feat(engagement): add notifications-category-sync skill - #188
Open
zelkibuilds wants to merge 2 commits into
Open
zelkibuilds wants to merge 2 commits into
zelkibuilds wants to merge 2 commits into
Conversation
Repo-agnostic workflow for syncing a client with the backend notifications category manifest, with a MetaMask Mobile overlay.
zelkibuilds
marked this pull request as ready for review
October 1, 2026 17:41
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
platform/notifications-category-sync, a repo-agnostic workflow for updating client category manifests, settings support, fallback snapshots, and tests. The MetaMask Mobile overlay maps the workflow to the current notification implementation, including inbox filtering and category-scoped mark-as-read behavior.Type of Change
Skill Details (if adding a new skill)
Provider Name: MetaMask
Skill Name: notifications-category-sync
Brief Description: Sync client support with changes to the backend-driven notification category manifest.
Checklist
Testing
git diff --checkpassed for the update.node .github/scripts/lint-skill-entry.mjsran, but exits with an existing description-length error intypescript/tsc-blindspots, outside this PR's files.yarn audit:skillscould not run because this checkout has no Yarn install state.Additional Context
The Mobile overlay documents that the current resolver uses the fallback for an empty category list, includes the inbox filtering and mark-as-read paths, and no longer promises that unsupported-category logs are deduplicated.