Skip to content

feat: add feature-flags skill with MetaMask Mobile overlay - #147

Merged
NicolasMassart merged 1 commit into
mainfrom
feat/MCWP-827_feature-flags
Sep 15, 2026
Merged

NicolasMassart merged 1 commit into
mainfrom
feat/MCWP-827_feature-flags

Conversation

@NicolasMassart

@NicolasMassart NicolasMassart commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adds feature-flags in the platform domain: shared skill.md, MetaMask Mobile overlay, and CHANGELOG. Marked base: true so it installs with the default base set.

Why a shared skill plus a repo overlay. skill.md is the workflow every consumer shares. repos/metamask-mobile.md is the Mobile wiring. A Mobile-only skill would be fewer files today; the next consumer would then copy or fork it. Overlay merge is the existing pattern in this repo.

Why base: true. Engineers who never select the platform domain still get this skill on postinstall, same as the other base skills. Relying on --include or SKILLS_DOMAINS=platform would miss most clones. Cost: always-on description tokens. --exclude / SKILLS_EXCLUDE still skips it.

Fixes MCWP-827.

Type of Change

  • New skill
  • Skill improvement/update
  • Bug fix
  • Documentation update
  • Other (please describe):

Skill Details (if adding a new skill)

Provider Name: MetaMask
Skill Name: feature-flags
Brief Description: Version-gated remote feature flags, with a MetaMask Mobile overlay for the canonical helper and selectors.

Checklist

  • I have read the CONTRIBUTING.md guidelines
  • My skill follows the SKILL_TEMPLATE.md format
  • I have tested this skill with an AI agent
  • My skill does not contain any secrets, private keys, or sensitive data
  • I have added appropriate documentation
  • My changes don't break existing skills

Testing

  • Confirm yarn audit:skills accepts the new skill frontmatter
  • Install the skill and confirm it is selected when adding or reviewing feature flags in MetaMask Mobile
  • Confirm base: true still installs the skill when its domain is filtered out
  • Confirm --exclude / SKILLS_EXCLUDE still skips it when explicitly excluded

Proof of testing the skill

See the generated skill test report: skill-test-feature-flags.local.md

Additional Context

MCWP-827

Made with Cursor

andrepimenta
andrepimenta previously approved these changes Sep 9, 2026
Comment thread CHANGELOG.md Outdated
andrepimenta
andrepimenta previously approved these changes Sep 11, 2026
andrepimenta
andrepimenta previously approved these changes Sep 11, 2026
@NicolasMassart
NicolasMassart force-pushed the feat/MCWP-827_feature-flags branch 2 times, most recently from 9790948 to 9aea3ce Compare September 15, 2026 10:49
@NicolasMassart
NicolasMassart force-pushed the feat/MCWP-827_feature-flags branch from 9aea3ce to 28fc543 Compare September 15, 2026 11:01
Base automatically changed from feat/MCWP-826_Analytics-skill to main September 15, 2026 11:14
@NicolasMassart
NicolasMassart force-pushed the feat/MCWP-827_feature-flags branch from 28fc543 to d02c4d8 Compare September 15, 2026 11:14
@NicolasMassart
NicolasMassart merged commit ea88099 into main Sep 15, 2026
28 checks passed
@NicolasMassart
NicolasMassart deleted the feat/MCWP-827_feature-flags branch September 15, 2026 11:36
matallui added a commit that referenced this pull request Sep 15, 2026
…-description-over-1024

* origin/main:
  feat: add navigation skill with MetaMask Mobile overlay (#148)
  feat: add feature-flags skill with MetaMask Mobile overlay (#147)
  feat: add analytics skill with MetaMask Mobile overlay (#140)
  feat: Adds `observability` domain with Sentry, Tempo, telemetry cost control skills (#76)
  refactor(perps): review skill composes the perps library instead of carrying knowledge copies (#159)

# Conflicts:
#	README.md
matallui added a commit that referenced this pull request Sep 15, 2026
…-description-over-1024

* origin/main:
  feat: add navigation skill with MetaMask Mobile overlay (#148)
  feat: add feature-flags skill with MetaMask Mobile overlay (#147)
  feat: add analytics skill with MetaMask Mobile overlay (#140)
  feat: Adds `observability` domain with Sentry, Tempo, telemetry cost control skills (#76)
  refactor(perps): review skill composes the perps library instead of carrying knowledge copies (#159)

# Conflicts:
#	README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants