Repository navigation
[create-release-branch] Release file doesn't always open automatically #68
Description
A small UX improvement would be to open the release file using the editor of choice. We could have a simple config file in the user's home folder which stores the command to run to open the file, and call that when creating the release file.
Activity
mcmire commentedon Jul 11, 2024
@Mrtenz Right now it checks for
EDITORand uses that first if it's defined: https://github.com/MetaMask/create-release-branch/blob/99b81d798cd5fc2b5771f4ddda8bb062c4f4f549/src/editor.ts#L27. Is that enough or do you feel like having a config file would be more reliable?mcmire commentedon Nov 12, 2024
Someone messaged me the other day and said that the tool didn't open an editor for them. They weren't using VSCode, they were using Cursor. So this is definitely still a problem.
We could support a config file, but I am not sure how many people would know about it. We could inform them about it as soon as the tool doesn't detect an editor. By then it would be a bit too late, they'd have to add the config file for next time, but that is definitely an option.
Alternatively, we could have the tool check for alternate editors — and do so by first checking for an executable, then a macOS app. We already check for the existence of
codehere but we could check for/Applications/Visual Studio Code.app/Contents/Resources/app/bin/codeinstead, and do a similar thing for Cursor. This way if the user has not installed thecodeexecutable it will continue to work.[-]Automatically open release file using editor of choice[/-][+]Release file doesn't always open automatically[/+][-]Release file doesn't always open automatically[/-][+][create-release-branch] Release file doesn't always open automatically[/+]