Skip to content

On-ramp: Remove unused constants - #5462

Merged
wachunei merged 2 commits into
mainfrom
chore/onramp-clean-constants
Jan 9, 2023
Merged

wachunei merged 2 commits into
mainfrom
chore/onramp-clean-constants

Conversation

@wachunei

@wachunei wachunei commented Jan 9, 2023

Copy link
Copy Markdown
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR removes unused constants related to on-ramp

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-money-movement issues related to Money Movement features Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking release-5.14.0 Issue or pull request that will be included in release 5.14.0 labels Jan 9, 2023
@wachunei
wachunei requested a review from a team as a code owner January 9, 2023 22:24

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment if there is time.

Comment thread app/constants/on-ramp.js
@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 9, 2023
@wachunei
wachunei merged commit ff7afa2 into main Jan 9, 2023
@wachunei
wachunei deleted the chore/onramp-clean-constants branch January 9, 2023 22:53
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-5.14.0 Issue or pull request that will be included in release 5.14.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-money-movement issues related to Money Movement features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants