Skip to content

Fix backButtonAction proptype - #7578

Merged
rickycodes merged 3 commits into
MetaMask:developfrom
rickycodes:fix-AccountModalContainer-proptype
Nov 26, 2019
Merged

rickycodes merged 3 commits into
MetaMask:developfrom
rickycodes:fix-AccountModalContainer-proptype

Conversation

@rickycodes

Copy link
Copy Markdown
Contributor

@whymarrh noticed another one of these and wasn't sure what the best path forward was so opening this to start a discussion

image

whymarrh
whymarrh previously approved these changes Nov 26, 2019

@whymarrh whymarrh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the correct solution! Thanks @rickycodes! 😅

whymarrh
whymarrh previously approved these changes Nov 26, 2019

@whymarrh whymarrh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickycodes
rickycodes merged commit 4a59fb4 into MetaMask:develop Nov 26, 2019
@rickycodes
rickycodes deleted the fix-AccountModalContainer-proptype branch November 26, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants