Convert NetworkDropdownIcon component to JSX - #7511
Merged
Merged
Conversation
whymarrh
force-pushed
the
hyperscript-8
branch
from
November 23, 2019 00:35
8e378a6 to
7e5fbea
Compare
Gudahtt
reviewed
Nov 23, 2019
Gudahtt
reviewed
Nov 23, 2019
…on.js Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ~~Depends on MetaMask/core#7624 ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/profile-metrics-controller` to `^3.0.0`. ```markdown ### Added - `ProfileMetricsController` contructor now accepts an optional `initialDelayDuration` parameter ([#7624](MetaMask/core#7624)) - The parameter can be used to override the default time-based delay for the first data collection after opt-in - Add `skipInitialDelay()` method to `ProfileMetricsController` ([#7624](MetaMask/core#7624)) - The method can be also called through the `ProfileMetricsController:skipInitialDelay` action via messenger ### Changed - **BREAKING:** `ProileMetricsControllerMessenger` now requires the `TransactionController:transactionSubmitted` action to be allowed ([#7624](MetaMask/core#7624)) - Set time-based delay for first `ProfileMetricsController` data collection after opt-in ([#7624](MetaMask/core#7624)) - Upgrade `@metamask/utils` from `^11.8.1` to `^11.9.0` ([#7511](MetaMask/core#7511)) - Bump `@metamask/controller-utils` from `^11.16.0` to `^11.18.0` ([#7534](MetaMask/core#7534), [#7583](MetaMask/core#7583)) - Bump `@metamask/accounts-controller` from `^35.0.0` to `^35.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) - Bump `@metamask/polling-controller` from `^16.0.0` to `^16.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/39270?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Upgrade and integration** > > - Bumps `@metamask/profile-metrics-controller` to `^3.0.0` and updates related deps; adds LavaMoat allowances for `@metamask/utils` > - Passes `initialDelayDuration` to `ProfileMetricsController` (10 min prod; 1s tests) > > **Skip flow and messaging** > > - Adds `ProfileMetricsController:skipInitialDelay` to `AppStateController` allowed actions and invokes it when `setPna25Acknowledged(true, true)` is called > - UI onboarding updates (`metametrics`, `welcome`) and Redux action now pass the extra flag to enable immediate collection skip > - `ProfileMetricsController` messenger now listens to `TransactionController:transactionSubmitted` > > **Tests** > > - Updates controller init test for new args and e2e description to reflect initial delay > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 62bb61c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
runway-github Bot
added a commit
that referenced
this pull request
Jan 19, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ~~Depends on MetaMask/core#7624 ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/profile-metrics-controller` to `^3.0.0`. ```markdown ### Added - `ProfileMetricsController` contructor now accepts an optional `initialDelayDuration` parameter ([#7624](MetaMask/core#7624)) - The parameter can be used to override the default time-based delay for the first data collection after opt-in - Add `skipInitialDelay()` method to `ProfileMetricsController` ([#7624](MetaMask/core#7624)) - The method can be also called through the `ProfileMetricsController:skipInitialDelay` action via messenger ### Changed - **BREAKING:** `ProileMetricsControllerMessenger` now requires the `TransactionController:transactionSubmitted` action to be allowed ([#7624](MetaMask/core#7624)) - Set time-based delay for first `ProfileMetricsController` data collection after opt-in ([#7624](MetaMask/core#7624)) - Upgrade `@metamask/utils` from `^11.8.1` to `^11.9.0` ([#7511](MetaMask/core#7511)) - Bump `@metamask/controller-utils` from `^11.16.0` to `^11.18.0` ([#7534](MetaMask/core#7534), [#7583](MetaMask/core#7583)) - Bump `@metamask/accounts-controller` from `^35.0.0` to `^35.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) - Bump `@metamask/polling-controller` from `^16.0.0` to `^16.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/39270?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Upgrade and integration** > > - Bumps `@metamask/profile-metrics-controller` to `^3.0.0` and updates related deps; adds LavaMoat allowances for `@metamask/utils` > - Passes `initialDelayDuration` to `ProfileMetricsController` (10 min prod; 1s tests) > > **Skip flow and messaging** > > - Adds `ProfileMetricsController:skipInitialDelay` to `AppStateController` allowed actions and invokes it when `setPna25Acknowledged(true, true)` is called > - UI onboarding updates (`metametrics`, `welcome`) and Redux action now pass the extra flag to enable immediate collection skip > - `ProfileMetricsController` messenger now listens to `TransactionController:transactionSubmitted` > > **Tests** > > - Updates controller init test for new args and e2e description to reflect initial delay > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 62bb61c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
runway-github Bot
added a commit
that referenced
this pull request
Jan 19, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ~~Depends on MetaMask/core#7624 ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/profile-metrics-controller` to `^3.0.0`. ```markdown ### Added - `ProfileMetricsController` contructor now accepts an optional `initialDelayDuration` parameter ([#7624](MetaMask/core#7624)) - The parameter can be used to override the default time-based delay for the first data collection after opt-in - Add `skipInitialDelay()` method to `ProfileMetricsController` ([#7624](MetaMask/core#7624)) - The method can be also called through the `ProfileMetricsController:skipInitialDelay` action via messenger ### Changed - **BREAKING:** `ProileMetricsControllerMessenger` now requires the `TransactionController:transactionSubmitted` action to be allowed ([#7624](MetaMask/core#7624)) - Set time-based delay for first `ProfileMetricsController` data collection after opt-in ([#7624](MetaMask/core#7624)) - Upgrade `@metamask/utils` from `^11.8.1` to `^11.9.0` ([#7511](MetaMask/core#7511)) - Bump `@metamask/controller-utils` from `^11.16.0` to `^11.18.0` ([#7534](MetaMask/core#7534), [#7583](MetaMask/core#7583)) - Bump `@metamask/accounts-controller` from `^35.0.0` to `^35.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) - Bump `@metamask/polling-controller` from `^16.0.0` to `^16.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/39270?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Upgrade and integration** > > - Bumps `@metamask/profile-metrics-controller` to `^3.0.0` and updates related deps; adds LavaMoat allowances for `@metamask/utils` > - Passes `initialDelayDuration` to `ProfileMetricsController` (10 min prod; 1s tests) > > **Skip flow and messaging** > > - Adds `ProfileMetricsController:skipInitialDelay` to `AppStateController` allowed actions and invokes it when `setPna25Acknowledged(true, true)` is called > - UI onboarding updates (`metametrics`, `welcome`) and Redux action now pass the extra flag to enable immediate collection skip > - `ProfileMetricsController` messenger now listens to `TransactionController:transactionSubmitted` > > **Tests** > > - Updates controller init test for new args and e2e description to reflect initial delay > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 62bb61c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
runway-github Bot
pushed a commit
that referenced
this pull request
Jan 19, 2026
…er cp-13.14.1 (#39270) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ~~Depends on MetaMask/core#7624 ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/profile-metrics-controller` to `^3.0.0`. ```markdown ### Added - `ProfileMetricsController` contructor now accepts an optional `initialDelayDuration` parameter ([#7624](MetaMask/core#7624)) - The parameter can be used to override the default time-based delay for the first data collection after opt-in - Add `skipInitialDelay()` method to `ProfileMetricsController` ([#7624](MetaMask/core#7624)) - The method can be also called through the `ProfileMetricsController:skipInitialDelay` action via messenger ### Changed - **BREAKING:** `ProileMetricsControllerMessenger` now requires the `TransactionController:transactionSubmitted` action to be allowed ([#7624](MetaMask/core#7624)) - Set time-based delay for first `ProfileMetricsController` data collection after opt-in ([#7624](MetaMask/core#7624)) - Upgrade `@metamask/utils` from `^11.8.1` to `^11.9.0` ([#7511](MetaMask/core#7511)) - Bump `@metamask/controller-utils` from `^11.16.0` to `^11.18.0` ([#7534](MetaMask/core#7534), [#7583](MetaMask/core#7583)) - Bump `@metamask/accounts-controller` from `^35.0.0` to `^35.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) - Bump `@metamask/polling-controller` from `^16.0.0` to `^16.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/39270?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Upgrade and integration** > > - Bumps `@metamask/profile-metrics-controller` to `^3.0.0` and updates related deps; adds LavaMoat allowances for `@metamask/utils` > - Passes `initialDelayDuration` to `ProfileMetricsController` (10 min prod; 1s tests) > > **Skip flow and messaging** > > - Adds `ProfileMetricsController:skipInitialDelay` to `AppStateController` allowed actions and invokes it when `setPna25Acknowledged(true, true)` is called > - UI onboarding updates (`metametrics`, `welcome`) and Redux action now pass the extra flag to enable immediate collection skip > - `ProfileMetricsController` messenger now listens to `TransactionController:transactionSubmitted` > > **Tests** > > - Updates controller init test for new args and e2e description to reflect initial delay > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 62bb61c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Gudahtt
pushed a commit
that referenced
this pull request
Jan 19, 2026
…er cp-13.14.1 (#39270) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ~~Depends on MetaMask/core#7624 ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/profile-metrics-controller` to `^3.0.0`. ```markdown ### Added - `ProfileMetricsController` contructor now accepts an optional `initialDelayDuration` parameter ([#7624](MetaMask/core#7624)) - The parameter can be used to override the default time-based delay for the first data collection after opt-in - Add `skipInitialDelay()` method to `ProfileMetricsController` ([#7624](MetaMask/core#7624)) - The method can be also called through the `ProfileMetricsController:skipInitialDelay` action via messenger ### Changed - **BREAKING:** `ProileMetricsControllerMessenger` now requires the `TransactionController:transactionSubmitted` action to be allowed ([#7624](MetaMask/core#7624)) - Set time-based delay for first `ProfileMetricsController` data collection after opt-in ([#7624](MetaMask/core#7624)) - Upgrade `@metamask/utils` from `^11.8.1` to `^11.9.0` ([#7511](MetaMask/core#7511)) - Bump `@metamask/controller-utils` from `^11.16.0` to `^11.18.0` ([#7534](MetaMask/core#7534), [#7583](MetaMask/core#7583)) - Bump `@metamask/accounts-controller` from `^35.0.0` to `^35.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) - Bump `@metamask/polling-controller` from `^16.0.0` to `^16.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/39270?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Upgrade and integration** > > - Bumps `@metamask/profile-metrics-controller` to `^3.0.0` and updates related deps; adds LavaMoat allowances for `@metamask/utils` > - Passes `initialDelayDuration` to `ProfileMetricsController` (10 min prod; 1s tests) > > **Skip flow and messaging** > > - Adds `ProfileMetricsController:skipInitialDelay` to `AppStateController` allowed actions and invokes it when `setPna25Acknowledged(true, true)` is called > - UI onboarding updates (`metametrics`, `welcome`) and Redux action now pass the extra flag to enable immediate collection skip > - `ProfileMetricsController` messenger now listens to `TransactionController:transactionSubmitted` > > **Tests** > > - Updates controller init test for new args and e2e description to reflect initial delay > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 62bb61c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Gudahtt
added a commit
that referenced
this pull request
Jan 19, 2026
…er cp-13.14.1 (#39359) - bump: @metamask/profile-metrics-controller cp-13.14.1 (#39270) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ~~Depends on MetaMask/core#7624 ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/profile-metrics-controller` to `^3.0.0`. ```markdown ### Added - `ProfileMetricsController` contructor now accepts an optional `initialDelayDuration` parameter ([#7624](MetaMask/core#7624)) - The parameter can be used to override the default time-based delay for the first data collection after opt-in - Add `skipInitialDelay()` method to `ProfileMetricsController` ([#7624](MetaMask/core#7624)) - The method can be also called through the `ProfileMetricsController:skipInitialDelay` action via messenger ### Changed - **BREAKING:** `ProileMetricsControllerMessenger` now requires the `TransactionController:transactionSubmitted` action to be allowed ([#7624](MetaMask/core#7624)) - Set time-based delay for first `ProfileMetricsController` data collection after opt-in ([#7624](MetaMask/core#7624)) - Upgrade `@metamask/utils` from `^11.8.1` to `^11.9.0` ([#7511](MetaMask/core#7511)) - Bump `@metamask/controller-utils` from `^11.16.0` to `^11.18.0` ([#7534](MetaMask/core#7534), [#7583](MetaMask/core#7583)) - Bump `@metamask/accounts-controller` from `^35.0.0` to `^35.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) - Bump `@metamask/polling-controller` from `^16.0.0` to `^16.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/39270?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Upgrade and integration of profile metrics delay** > > - Bumps `@metamask/profile-metrics-controller` to `^3.0.0`; initializes with `initialDelayDuration` (test: 1s, prod: 10m) > - Adds `ProfileMetricsController:skipInitialDelay` action to `AppStateController` messenger and invokes it when `setPna25Acknowledged(true, true)` is called > - Updates Profile Metrics messenger to require `TransactionController:transactionSubmitted` event > - Adjusts UI (`metametrics` and `welcome`) and `setPna25Acknowledged` action to support optional delay skipping; updates tests accordingly > - Updates LavaMoat policies and bumps related packages (`network-controller`, `polling-controller`, `gas-fee-controller`, `json-rpc-engine`, `eth-block-tracker`, etc.) > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit f32290f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> [dba4a74](dba4a74) --------- Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com> Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Mark Stacey <mark.stacey@consensys.net>
wantedsystem
pushed a commit
that referenced
this pull request
Jan 27, 2026
](https://codespaces.new/MetaMask/metamask-extension/pull/39270?quickstart=1){kind=link}
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ~~Depends on MetaMask/core#7624 ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/profile-metrics-controller` to `^3.0.0`. ```markdown ### Added - `ProfileMetricsController` contructor now accepts an optional `initialDelayDuration` parameter ([#7624](MetaMask/core#7624)) - The parameter can be used to override the default time-based delay for the first data collection after opt-in - Add `skipInitialDelay()` method to `ProfileMetricsController` ([#7624](MetaMask/core#7624)) - The method can be also called through the `ProfileMetricsController:skipInitialDelay` action via messenger ### Changed - **BREAKING:** `ProileMetricsControllerMessenger` now requires the `TransactionController:transactionSubmitted` action to be allowed ([#7624](MetaMask/core#7624)) - Set time-based delay for first `ProfileMetricsController` data collection after opt-in ([#7624](MetaMask/core#7624)) - Upgrade `@metamask/utils` from `^11.8.1` to `^11.9.0` ([#7511](MetaMask/core#7511)) - Bump `@metamask/controller-utils` from `^11.16.0` to `^11.18.0` ([#7534](MetaMask/core#7534), [#7583](MetaMask/core#7583)) - Bump `@metamask/accounts-controller` from `^35.0.0` to `^35.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) - Bump `@metamask/polling-controller` from `^16.0.0` to `^16.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/39270?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Upgrade and integration** > > - Bumps `@metamask/profile-metrics-controller` to `^3.0.0` and updates related deps; adds LavaMoat allowances for `@metamask/utils` > - Passes `initialDelayDuration` to `ProfileMetricsController` (10 min prod; 1s tests) > > **Skip flow and messaging** > > - Adds `ProfileMetricsController:skipInitialDelay` to `AppStateController` allowed actions and invokes it when `setPna25Acknowledged(true, true)` is called > - UI onboarding updates (`metametrics`, `welcome`) and Redux action now pass the extra flag to enable immediate collection skip > - `ProfileMetricsController` messenger now listens to `TransactionController:transactionSubmitted` > > **Tests** > > - Updates controller init test for new args and e2e description to reflect initial delay > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 62bb61c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
wantedsystem
pushed a commit
that referenced
this pull request
Jan 27, 2026
…er cp-13.14.1 (#39359) - bump: @metamask/profile-metrics-controller cp-13.14.1 (#39270) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ~~Depends on MetaMask/core#7624 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/profile-metrics-controller` to `^3.0.0`. ```markdown - `ProfileMetricsController` contructor now accepts an optional `initialDelayDuration` parameter ([#7624](MetaMask/core#7624)) - The parameter can be used to override the default time-based delay for the first data collection after opt-in - Add `skipInitialDelay()` method to `ProfileMetricsController` ([#7624](MetaMask/core#7624)) - The method can be also called through the `ProfileMetricsController:skipInitialDelay` action via messenger - **BREAKING:** `ProileMetricsControllerMessenger` now requires the `TransactionController:transactionSubmitted` action to be allowed ([#7624](MetaMask/core#7624)) - Set time-based delay for first `ProfileMetricsController` data collection after opt-in ([#7624](MetaMask/core#7624)) - Upgrade `@metamask/utils` from `^11.8.1` to `^11.9.0` ([#7511](MetaMask/core#7511)) - Bump `@metamask/controller-utils` from `^11.16.0` to `^11.18.0` ([#7534](MetaMask/core#7534), [#7583](MetaMask/core#7583)) - Bump `@metamask/accounts-controller` from `^35.0.0` to `^35.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) - Bump `@metamask/polling-controller` from `^16.0.0` to `^16.0.2` ([#7604](MetaMask/core#7604), [#7642](MetaMask/core#7642)) ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/39270?quickstart=1) <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null Fixes: 1. Go to this page... 2. 3. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Upgrade and integration of profile metrics delay** > > - Bumps `@metamask/profile-metrics-controller` to `^3.0.0`; initializes with `initialDelayDuration` (test: 1s, prod: 10m) > - Adds `ProfileMetricsController:skipInitialDelay` action to `AppStateController` messenger and invokes it when `setPna25Acknowledged(true, true)` is called > - Updates Profile Metrics messenger to require `TransactionController:transactionSubmitted` event > - Adjusts UI (`metametrics` and `welcome`) and `setPna25Acknowledged` action to support optional delay skipping; updates tests accordingly > - Updates LavaMoat policies and bumps related packages (`network-controller`, `polling-controller`, `gas-fee-controller`, `json-rpc-engine`, `eth-block-tracker`, etc.) > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit f32290f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> [dba4a74](dba4a74) --------- Co-authored-by: Michele Esposito <34438276+mikesposito@users.noreply.github.com> Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Mark Stacey <mark.stacey@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #6291
This PR replaces hyperscript in the
NetworkDropdownIconcomponent with JSX.