chore: temp integration of advanced charts - #45271
Draft
sahar-fehri wants to merge 2 commits into
Draft
sahar-fehri wants to merge 2 commits into
sahar-fehri wants to merge 2 commits into
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (1 files, +5 -0)
👨🔧 @itsyoboieltr (1 files, +5 -0)
|
Contributor
Author
|
TradingView's charting_library.js needs to reach into its own inner <iframe> via same-origin DOM access. In the extension we're forced to host the chart in a sandboxed page, which Chrome gives an opaque origin ("null"). Same-origin access from a "null" origin is blocked, so TradingView throws before the chart can mount. This seems to be a Chrome MV3 wall. 
|
sahar-fehri
commented
Aug 6, 2026
| * @param options - Widget construction options (datafeed, formatters, etc.). | ||
| * @returns The constructed TradingView widget. | ||
| */ | ||
| function createChartWidget(config, options) { |
Contributor
Author
There was a problem hiding this comment.
This chartLogic.iife.js is the compiled IIFE of the shared @metamask/advanced-chart-core engine, hand-copied from mobile's build output just to prototype the extension TDP integration. The extension isn't wired to core — there's no dependency and nothing rebuilds this file; it exists only for this temporary spike.
createChartWidget here is the last line of our code before it hands off to TradingView's proprietary charting_library.js (new TvWidget(...)), which is where the opaque-origin SecurityError is thrown
Follow-up: replace this copy by adding @metamask/advanced-chart-core as a real dependency and bundling it via webpack (like mobile) MetaMask/core#9762
Contributor
Builds ready [0f72070]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 10 warn · 🔴 3 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [5ba767f]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 9 warn · 🔴 2 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Related: #45233
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist