Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This was referenced Jan 13, 2026
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
Ignoring alerts on:
|
Contributor
Author
|
@SocketSecurity ignore npm/@metamask/gas-fee-controller@26.0.1 This is a MetaMask-owned package ( |
Contributor
Builds ready [bafa023]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [464b89d]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
metamaskbot
temporarily deployed
to
pr-comment
January 14, 2026 10:46 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
✨ Files requiring CODEOWNER review ✨🕵️ @MetaMask/extension-privacy-reviewers (1 files, +1 -0)
📜 @MetaMask/policy-reviewers (5 files, +179 -5)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🧪 @MetaMask/qa (1 files, +1 -0)
🔄 @MetaMask/swaps-engineers (1 files, +1 -0)
|
metamaskbot
had a problem deploying
to
pr-comment
January 14, 2026 11:15 — with
GitHub Actions
Error
GitHub Actions
Error
Contributor
Builds ready [914ca1c]
UI Startup Metrics (1268 ± 122 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-merge-queue Bot
pushed a commit
to MetaMask/core
that referenced
this pull request
Jan 14, 2026
) ## Explanation ### Current State The `NetworkEnablementController` tracks which networks are enabled/disabled but lacks information about the native asset identifier for each chain. This information is needed to properly identify native assets across different blockchain networks using a standardized format. Extension UI PR: MetaMask/metamask-extension#39234 ### Solution This PR adds a new state property `nativeAssetIdentifiers` to the `NetworkEnablementController` that maps CAIP-2 chain IDs to CAIP-19-like native asset identifiers. For example: - `eip155:1` → `eip155:1/slip44:60` (Ethereum uses ETH, SLIP-44 coin type 60) - `eip155:56` → `eip155:56/slip44:714` (BSC uses BNB, SLIP-44 coin type 714) - `solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp` → `solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/slip44:501` ### Implementation Details 1. **New `Slip44Service`**: A service that wraps the `@metamask/slip44` package to look up SLIP-44 coin types by symbol (e.g., `ETH` → `60`, `BTC` → `0`). 2. **State Updates**: The `nativeAssetIdentifiers` state is automatically updated when: - A network is added (`NetworkController:networkAdded`) - A network is removed (`NetworkController:networkRemoved`) - A network's native currency symbol is changed (`NetworkController:stateChange`) 3. **Default State**: Popular networks are pre-populated with their correct native asset identifiers based on their native currency symbols. 4. **Graceful Handling**: If a symbol has no SLIP-44 mapping, the entry is removed from the state rather than storing an invalid identifier. ### Dependency Addition Added `@metamask/slip44` package to dynamically look up SLIP-44 coin types instead of hardcoding them, ensuring accuracy and maintainability. ## References - [SLIP-44 Standard](https://github.com/satoshilabs/slips/blob/master/slip-0044.md) - [CAIP-2 Chain ID Specification](https://github.com/ChainAgnostic/CAIPs/blob/main/CAIPs/caip-2.md) - [CAIP-19 Asset Identifier Specification](https://github.com/ChainAgnostic/CAIPs/blob/main/CAIPs/caip-19.md) - [@metamask/slip44 npm package](https://www.npmjs.com/package/@metamask/slip44) ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Introduces native asset tracking and supporting utilities. > > - Adds `nativeAssetIdentifiers` mapping (CAIP-2 -> `.../slip44:<coinType>`) to `NetworkEnablementController` state and metadata > - New `Slip44Service` (uses `@metamask/slip44` and chainid.network) to resolve coin types by symbol/chainId; exports helpers > - Makes `init()` async and populates EVM identifiers; new `initNativeAssetIdentifiers(networks)` API for bulk initialization > - Updates network lifecycle: on add (async) computes and stores identifier; on remove deletes identifier > - Extends public exports (types, service) and adds `@metamask/slip44` dependency > - Updates/extends tests for controller, selectors, utils, and new service > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit f8cdcfc. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2026-01-13.at.15.32.37.mov
Pre-merge author checklist
Pre-merge reviewer checklist