Skip to content

Use Node16 for module + moduleResolution; support *.mts files #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcmire merged 3 commits into from
Oct 23, 2026
Merged

Use Node16 for module + moduleResolution; support *.mts files #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a33e21
Use Node16 for module + moduleResolution; support *.mts files
mcmire Oct 23, 2026
a78baec
Update coverage thresholds
mcmire Oct 23, 2026
2c231f1
Make sure ESLint sees .mts files
mcmire Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .depcheckrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"parsers": {
"**/*.mjs": "es6",
"**/*.ts": "typescript"
"**/*.ts": "typescript",
"**/*.mts": "typescript"
},
"ignores": [
"@lavamoat/allow-scripts",
Expand Down
6 changes: 3 additions & 3 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,20 @@ module.exports = {

overrides: [
{
files: ['*.ts'],
files: ['*.ts', '*.mts'],
extends: ['@metamask/eslint-config-typescript'],
},

{
files: ['*.js', '*.ts'],
files: ['*.js', '*.ts', '*.mts'],
parserOptions: {
sourceType: 'script',
},
extends: ['@metamask/eslint-config-nodejs'],
},

{
files: ['*.mjs'],
files: ['*.mjs', '*.mts'],
parserOptions: {
sourceType: 'module',
ecmaVersion: 2022,
Expand Down
8 changes: 4 additions & 4 deletions jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ module.exports = {
// An object that configures minimum threshold enforcement for coverage results
coverageThreshold: {
global: {
branches: 49.56,
functions: 55.62,
lines: 56.13,
statements: 56.19,
branches: 60.84,

@mcmire mcmire Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why these went up 🤷🏻 But I'll take it!

functions: 62.25,
lines: 65.68,
statements: 65.84,
},
},

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@
"url": "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/MetaMask/github-tools.git"
},
"scripts": {
"changelog:check": "ts-node src/changelog-check.ts",
"changelog:check": "node --loader ts-node/esm src/changelog-check.mts",

@mcmire mcmire Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes yarn changelog:check to produce a warning that --loader is experimental. It may or may not work in future versions of Node.

If we can upgrade Node then we may be able to take advantage of Node's type-stripping feature and then we can drop ts-node entirely:

    "changelog:check": "node src/changelog-check.mts",

But maybe this is okay for now?

@HowardBraham HowardBraham Oct 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be nice to drop ts-node. We dropped it in the Extension.

Comment thread
cursor[bot] marked this conversation as resolved.
"count-references-to-contributor-docs": "ts-node --swc src/scripts/count-references-to-contributor-docs/cli.ts",
"gen:commits": "node .github/scripts/generate-rc-commits.mjs",
"get-review-metrics": "ts-node src/get-review-metrics.ts",
"lint": "yarn lint:tsc && yarn lint:eslint && yarn lint:constraints && yarn lint:misc --check && yarn lint:dependencies --check",
"lint:constraints": "yarn constraints",
"lint:changelog": "auto-changelog validate --prettier",
"lint:dependencies": "depcheck && yarn dedupe",
"lint:eslint": "eslint . --cache --ext js,ts && eslint --no-ignore --cache --ext mjs .github/actions/draft-segment-schema-pr",
"lint:eslint": "eslint . --cache --ext js,ts,mts && eslint --no-ignore --cache --ext mjs .github/actions/draft-segment-schema-pr",
"lint:fix": "yarn lint:eslint --fix && yarn lint:constraints --fix && yarn lint:misc --write && yarn lint:dependencies",
"lint:misc": "prettier '**/*.json' '**/*.md' '**/*.yml' '!.yarnrc.yml' '!.cursor/**' --ignore-path .gitignore --no-error-on-unmatched-pattern",
"lint:tsc": "tsc",
Expand Down
0 src/changelog-check.ts → src/changelog-check.mts
View file
Open in desktop
File renamed without changes.
5 changes: 3 additions & 2 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@
"exactOptionalPropertyTypes": true,
"forceConsistentCasingInFileNames": true,
"lib": ["ES2022"],
"module": "CommonJS",
"moduleResolution": "node",
"module": "Node16",
"moduleResolution": "Node16",
"noEmit": true,
"noErrorTruncation": true,
"noUncheckedIndexedAccess": true,
"skipLibCheck": true,
"strict": true,
"target": "es2020"
},
Expand Down
Loading