Repository navigation
Add TypeScript type definitions - #2
Merged
Merged
Conversation
TypeScript will refuse to build a project that relies on `eth-query`, as it lacks type definitions. We have previously gotten around this in the extension and in `core` by supplying those type definitions directly in the project itself, but this is causing issues especially for the Snaps team, who now wish to use `@metamask/controller-utils`, which names `eth-query` as a dependency. This commit copies the type definitions from the `core` monorepo into this repo. They were previously copied from the extension, so they have been battle-tested pretty well now.
Gudahtt
approved these changes
Jul 6, 2023
Gudahtt
left a comment
Gudahtt
left a comment
Member
There was a problem hiding this comment.
LGTM!
It'd be nice to convert the whole thing to TypeScript, so that we get proper type definitions for all methods rather than just sendAsync. But this is a good start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript will refuse to build a project that relies on
eth-query, as it lacks type definitions. We have previously gotten around this in the extension and incoreby supplying those type definitions directly in the project itself, but this is causing issues especially for the Snaps team, who now wish to use@metamask/controller-utils, which nameseth-queryas a dependency.This commit copies the type definitions from the
coremonorepo into this repo. They were previously copied from the extension, so they have been battle-tested pretty well now.Fixes #1.
Fixes MetaMask/core#1471.