Repository navigation
Reorganize src/ - #190
Reorganize src/#190mcmire wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
e058a38 to
803ad00
Compare
It's hard to tell how the UI code is using the code that was originally added for the CLI. This commit splits out common code into a `core/` directory while keeping the code unique to the CLI and UI in separate `cli/` and `ui/` directories.
803ad00 to
65bc3b1
Compare
| export default defineConfig({ | ||
| plugins: [react(), tailwindcss()], | ||
| root: 'src/ui', | ||
| root: 'src/ui/app', |
There was a problem hiding this comment.
Pay particular attention to this. We want to make sure that these paths are correct and match what is being used in (what is now) ui/app/start.ts. (Note, I moved dist/ui to dist/ui/build so that the source for the app is in a different place than the compiled output.
There was a problem hiding this comment.
I moved this from src/, renamed it from dirname.ts, and changed it to return the "root" directory from the perspective of the source files (either src/ or dest/ depending on development or production).
|
This library has now been migrated into the release-tools monorepo. This PR has been locked and this repo will be archived shortly. Going forward, releases of this library will only include changes made in the release-tools repo.
|
This branch has not been deployed
2 participants
It's hard to tell how the UI code is using the code that was originally added for the CLI. This commit splits out common code into a
core/directory while keeping the code unique to the CLI and UI in separatecli/andui/directories.Manual testing steps
yarn build.coreto use the local version of this repo.create-release-branch. Test that it works as expected.create-release-branch -i. Test that it works as expected.