fix(gas-fee-controller): make GasFeeController initialization-order-agnostic

[sirtimid]

Explanation

The GasFeeController constructor was the only currently-wired-or-wireable controller that performed eager, construction-time reads of NetworkController and the network provider:

• new EthQuery(this.#getProvider()) — unconditional.
• Seeding currentChainId — either via an eager getChainId() call or via NetworkController:getState + getNetworkClientById.

This forced any shared initialization (e.g. @metamask/wallet) to guarantee NetworkController is constructed before GasFeeController, which is exactly the construction-order coupling we want to avoid. Every other order-agnostic controller resolves its collaborators lazily.

This PR defers those reads to first use so the controller can be constructed in any order, matching the pattern already used elsewhere. No public API change — the constructor signature and gas-fee-fetching behavior are unchanged.

Changes

• Removed the eager EthQuery build and the eager currentChainId seeding from the constructor. Network-change subscription wiring is kept as-is (subscribing is safe regardless of construction order).
• Added lazy, memoized resolution:
  • #getEthQuery() — builds the EthQuery from getProvider on first use.
  • #getCurrentChainId() — resolves the chain ID from the getChainId callback when provided (only when paired with onNetworkDidChange, preserving the original coupling), otherwise from NetworkController.
• #onNetworkControllerDidChange now resets ethQuery to undefined (rebuilt lazily on the next fetch) instead of rebuilding it eagerly per network change, and still updates currentChainId.

Testing

• New tests assert construction performs no NetworkController:getState / getNetworkClientById / getProvider / getChainId calls — even when those handlers throw — for both the callback and no-callback constructor branches.
• New test covers network-change handling via both the onNetworkDidChange callback and the NetworkController:networkDidChange messenger subscription (chain ID + eth query update on the next fetch).
• All existing tests pass unchanged (53 total). 100% coverage on the changed lines; remaining uncovered lines are pre-existing.

References

Splits out the root-cause fix from the wiring PR #9527, so that GasFeeController can be migrated into the shared @metamask/wallet init set without a dependency-ordering mechanism.

🤖 Generated with Claude Code

---

Note

Medium Risk
Touches core gas-estimation initialization and network-switch caching; behavior is intended to stay the same but timing of first network reads shifts to first fetch.

Overview
GasFeeController no longer touches NetworkController or the RPC provider during construction, so it can be instantiated before the network stack is ready (e.g. shared @metamask/wallet init) without changing the public constructor or fetch semantics.

The constructor drops eager EthQuery creation and immediate chain-ID resolution (getChainId() / getState + getNetworkClientById). Instead, #getEthQuery() and #getCurrentChainId() memoize provider and chain ID on first use inside _fetchGasFeeEstimateData. When onNetworkDidChange + getChainId are supplied, the callback is stored without calling getChainId at construct time.

On network change, #onNetworkControllerDidChange clears the cached ethQuery (rebuilt on the next fetch) and still updates currentChainId and polling. Tests lock in zero constructor-time network/provider/getChainId calls and correct chain ID + provider refresh after network switches via callback or NetworkController:networkDidChange.

^{Reviewed by Cursor Bugbot for commit 66c249d. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit b0a9c28. Configure here.}

[matthewwalsh0]

Thanks! Absolutely out of scope for this PR but we can probably simplify this loads by removing the global / selected chain support as that predates the multi-chain / PollingController support which should be the only route needed now