Repository navigation
Rename "Collectible" to "NFT" - #934
Merged
Merged
Conversation
Gudahtt
force-pushed
the
rename-collectible-to-nft
branch
3 times, most recently
from
October 12, 2022 18:10
9127a01 to
93828a4
Compare
Gudahtt
marked this pull request as ready for review
October 12, 2022 18:21
adonesky1
previously approved these changes
Oct 12, 2022
adonesky1
left a comment
adonesky1
left a comment
Contributor
There was a problem hiding this comment.
Didn't review every single line but LGTM!
mcmire
reviewed
Oct 12, 2022
mcmire
left a comment
mcmire
left a comment
Collaborator
There was a problem hiding this comment.
Noticed one typo but otherwise this looks good to me.
The term "collectible" has been replaced by "NFT" everywhere. The term "collectible" was originally used because it was thought NFT would be more difficult for users to understand, but today in practice we all use the term NFT. Efforts to use the term "collectible" have long been abandoned.
Gudahtt
force-pushed
the
rename-collectible-to-nft
branch
from
October 12, 2022 21:05
5097aa6 to
380b2fb
Compare
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
The term "collectible" has been replaced by "NFT" everywhere. The term "collectible" was originally used because it was thought NFT would be more difficult for users to understand, but today in practice we all use the term NFT. Efforts to use the term "collectible" have long been abandoned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The term "collectible" has been replaced by "NFT" everywhere. The term "collectible" was originally used because it was thought NFT would be more difficult for users to understand, but today in practice we all use the term NFT. Efforts to use the term "collectible" have long been abandoned.
BREAKING:
CollectiblesControllertoNftController, and rename all methods, controller properties, types, constants, and state properties to use the term "NFT" instead of "collectible".CollectibleDetectionControllertoNftDetectionController, and rename all methods, controller properties, types, constants, and state properties to use the term "NFT" instead of "collectible".AssetsContractControllermethodgetERC721CollectibleTokenIdtogetERC721NftTokenId.assetsUtilmethodcompareCollectiblesMetadatatocompareNftMetadata.ASSET_TYPES.COLLECTIBLEtoASSET_TYPES.NFTPreferencesControllerstate propertyuseCollectibleDetectiontouseNftDetectionPreferenceControllermethodsetUseCollectibleDetectiontosetUseNftDetectionChecklist