Repository navigation
chore(smart-transactions-controller): reset CHANGELOG after migration - #9131
Merged
cryptodev-2s merged 1 commit intoJun 15, 2026
Merged
Conversation
Replaces the imported CHANGELOG history with a fresh skeleton and a single [Unreleased] entry that links back to the historical changelog in the original repo at the v24.2.1 tag. Per Phase B PR #7 of the package-migration-process-guide.
cryptodev-2s
temporarily deployed
to
default-branch
June 15, 2026 20:22 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Mrtenz
approved these changes
Jun 15, 2026
cryptodev-2s
deleted the
chore/smart-transactions-controller-reset-changelog
branch
June 15, 2026 20:40
4 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jun 15, 2026
…9132) ## Explanation Phase B PR #8 of the [package migration process guide](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md) for [\`@metamask/smart-transactions-controller\`](https://github.com/MetaMask/core/tree/main/merged-packages/smart-transactions-controller). Removes files that are either handled at the monorepo root or no longer needed once the package lives in core: | Removed | Reason | |---|---| | \`.github/\` | Workflows, CODEOWNERS, dependabot, PR template handled by core's root \`.github/\` | | \`.gitattributes\`, \`.gitignore\` | Root-level | | \`.editorconfig\`, \`.nvmrc\` | Root-level | | \`.prettierrc.js\`, \`eslint.config.mjs\` | Replaced by the monorepo root configs (next PR wires the package up to them) | | \`.yarn/\`, \`.yarnrc.yml\`, \`yarn.lock\` | Monorepo uses Yarn 4 with a single root lockfile | | \`scripts/\` | Source-repo release/preview scripts no longer needed | **Kept** (matches the guide's "Keep" list): \`src/\`, \`tests/\`, \`CHANGELOG.md\`, \`LICENSE\`, \`package.json\`, \`README.md\`, \`jest.config.js\`, \`tsconfig*.json\`, \`typedoc.json\`, \`setupJest.js\` (the last one will be decided in PR #9 when configs are replaced). No code or runtime behaviour changes. ## References - Prior steps: history merge (#9130), CHANGELOG reset (#9131) - Migration process: [\`docs/processes/package-migration-process-guide.md\`](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md) ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
This was referenced Jun 15, 2026
pull Bot
pushed a commit
to Reality2byte/core
that referenced
this pull request
Jun 16, 2026
…th monorepo (MetaMask#9136) ## Explanation Phase B PR #10 of the [package migration process guide](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md) for [\`@metamask/smart-transactions-controller\`](https://github.com/MetaMask/core/tree/main/merged-packages/smart-transactions-controller). Slims \`package.json\` down to match other non-root packages (modelled on \`packages/transaction-controller/package.json\`). ### Scripts - **Build** swapped to the monorepo standard \`ts-bridge ... --verbose --clean --no-references\`; added \`build:all\`, \`build:docs\`. - Added monorepo-standard \`changelog:update\`, \`changelog:validate\`, \`since-latest-release\`, \`test:clean\`, \`test:verbose\`, \`test:watch\`. - \`messenger-action-types:check\`/\`:generate\` now invoke the workspace messenger-cli via \`tsx ../../packages/messenger-cli/src/cli.ts\` instead of the package-local binary. - \`test\` reduced to \`jest --reporters=jest-silent-reporter\` (drops \`attw --pack\`; the dep that backed it is also removed below). - Removed all \`lint*\` scripts and \`prepack\` — lint runs at the monorepo root, prepack is root-handled. ### DevDeps | Removed (provided by root) | Kept (per-package toolchain) | |---|---| | \`@arethetypeswrong/cli\` (no longer used) | \`@metamask/auto-changelog\` | | \`@lavamoat/allow-scripts\` | \`@metamask/gas-fee-controller\` (test helper) | | \`@lavamoat/preinstall-always-fail\` | \`@metamask/json-rpc-engine\` (test helper) | | \`@metamask/eslint-config*\` | \`@ts-bridge/cli\` | | \`@metamask/messenger-cli\` (now invoked via \`tsx + path\`) | \`deepmerge\` | | \`eslint\`, \`eslint-*\` | \`jest\` | | \`isomorphic-fetch\` | \`nock\` | | \`prettier\`, \`prettier-plugin-packagejson\` | \`ts-jest\` | | \`typescript-eslint\` | \`typescript\` (kept per guide exception) | | | \`tsx\`, \`typedoc\`, \`typedoc-plugin-missing-exports\` (added) | ### Other - \`repository.url\` updated to point at \`MetaMask/core\`. - Added required workspace fields: \`keywords\`, \`homepage\`, \`bugs\`. Description now ends with a period. - Removed the dangling \`peerDependenciesMeta\` block (it had no matching \`peerDependencies\` entries). - Removed per-package \`lavamoat\` config and \`packageManager\` — both handled at the monorepo root. ### Known holdout \`nock\` is intentionally kept at \`^14.0.0-beta.7\` rather than aligning to root's \`^13.3.1\` — downgrade breaks 22 tests. Will be resolved in Phase C PR #12 via either an \`ALLOWED_INCONSISTENT_DEPENDENCIES\` entry or a core-side nock bump. Package is still in \`merged-packages/\` so \`yarn install\` doesn't actually exercise this manifest yet; it's verified in PR #12 when the package moves into \`packages/\`. ## References - Prior steps: history merge (MetaMask#9130), CHANGELOG reset (MetaMask#9131), strip files (MetaMask#9132), replace configs (MetaMask#9134) - Migration process: [\`docs/processes/package-migration-process-guide.md\`](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md) ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
This was referenced Jun 16, 2026
amitabh94
pushed a commit
to amitabh94/core
that referenced
this pull request
Jun 16, 2026
) ## Explanation **Phase C PR MetaMask#12** of the [package migration process guide](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md) for [`@metamask/smart-transactions-controller`](https://github.com/MetaMask/core/tree/main/packages/smart-transactions-controller). Final move from `merged-packages/` into `packages/` plus the wiring needed for `yarn install`, `yarn workspace ... test`, `yarn constraints`, and the README/CHANGELOG checks to pass. ### Changes - **Moved**: `git mv merged-packages/smart-transactions-controller packages/` (renames only, no content drift). Removed the now-empty `merged-packages/` directory. - **Root tsconfigs**: added `./packages/smart-transactions-controller` and `./packages/smart-transactions-controller/tsconfig.build.json` references (alphabetical). - **Root `README.md`**: ran `yarn readme-content:update` to add the package to the package list + the mermaid dependency graph. - **`yarn.config.cjs`**: added `@metamask/smart-transactions-controller` to the license-exception list. It carries a ConsenSys non-commercial `LICENSE` we did not relicense to MIT. - **`.github/CODEOWNERS`** + **`teams.json`**: registered ownership to `@MetaMask/transactions` / `team-transactions` (added a new "Transactions Team" section in `CODEOWNERS`). - **`packages/smart-transactions-controller/package.json`**: - Aligned `nock` from `^14.0.0-beta.7` → `^13.3.1` to match the rest of the monorepo. The v14-beta mock incompatibilities we saw in the source-repo context don't surface under the monorepo's `jest.config.packages.js` setup — 196/196 tests pass on nock 13. - Dropped 4 unused deps flagged by knip: `@ethereumjs/tx`, `@ethereumjs/util`, `fast-json-patch` (runtime), `@metamask/gas-fee-controller` (dev). - `yarn constraints --fix` stripped the trailing period from `description`. - **`packages/smart-transactions-controller/jest.config.js`**: dropped the `setupFiles: ['./setupJest.js']` override and the `testTimeout: 2500` override. Core's root `tests/setup.ts` already clears Node's native fetch and loads `isomorphic-fetch` (a superset of what `setupJest.js` did); Jest's default 5000ms timeout is more generous than the previous 2500ms. Coverage thresholds kept at the source-repo's originals (95% achieved comfortably exceeds them). - **`packages/smart-transactions-controller/setupJest.js`**: deleted (now redundant). - **`packages/smart-transactions-controller/CHANGELOG.md`**: documented the migration + dropped deps under `[Unreleased]` and added the `[Unreleased]` link reference required by `auto-changelog` v6. - **Formatting**: applied oxfmt fixes to `package.json` + `SmartTransactionsController.test.ts`. ### Testing - Preview Test in Mobile: MetaMask/metamask-mobile#31804 - Preview Test in Extension: MetaMask/metamask-extension#43610 ### Verification - ✅ `yarn install` - ✅ `yarn workspace @metamask/smart-transactions-controller test` — 196/196 pass; ~95% coverage - ✅ `yarn workspace @metamask/smart-transactions-controller build` - ✅ `yarn constraints` - ✅ `yarn lint:teams` - ✅ `yarn knip --dependencies` (clean for this package) - ✅ `yarn workspace @metamask/smart-transactions-controller changelog:validate` - ✅ `yarn lint:misc` (oxfmt) - ✅ `yarn readme-content:check` ### Downstream No core package currently depends on `@metamask/smart-transactions-controller`, so this PR contains no downstream version-bump or CHANGELOG updates. ## References - Prior steps: history merge (MetaMask#9130), CHANGELOG reset (MetaMask#9131), strip files (MetaMask#9132), replace configs (MetaMask#9134), align deps + scripts (MetaMask#9136), README update (MetaMask#9138) - Migration process: [`docs/processes/package-migration-process-guide.md`](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md) ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Phase B PR #7 of the package migration process guide for `@metamask/smart-transactions-controller`.
Replaces the imported `CHANGELOG.md` with a fresh skeleton plus a single `[Unreleased]` entry that links back to the historical changelog at the `v24.2.1` tag in the original repo. Subsequent CHANGELOG entries (from PRs in this monorepo) will accumulate under `[Unreleased]` until the first post-migration release.
References
@metamask/smart-transactions-controllerhistory intomerged-packages/#9130)Checklist