Repository navigation
Follow up to eth-json-rpc-middleware rewrite PR - #7138
Merged
Merged
Conversation
The following changes extend c26899a: - `eth-json-rpc-middleware` - There were some unnecessary type assertions in `inflight-cache.ts` that have been removed. - `message-manager` - The rename of `OriginalRequest` introduced a breaking change. We don't strictly need to do this now, so we keep the old type around for backward compatibility. - `network-controller` - The changelog has been updated to mention that a new export was added, and to detail more changes to `createWalletMiddleware`. - The signatures of `request` in `RpcServiceRequestable` and `RpcServiceChain` were updated to match the same method in `RpcService` (and the change to `RpcServiceRequestable` was marked as breaking).
mcmire
force-pushed
the
ejrpc-rewrite-followups
branch
from
November 12, 2025 19:10
bc11646 to
ca59fe6
Compare
mcmire
marked this pull request as ready for review
November 12, 2025 19:16
mcmire
enabled auto-merge
November 18, 2025 20:27
mcmire
disabled auto-merge
November 18, 2025 20:27
OGPoyraz
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The following changes extend c26899a:
eth-json-rpc-middlewareinflight-cache.tsthat have been removed.message-managerOriginalRequestintroduced a breaking change. We don't strictly need to do this now, so we keep the old type around for backward compatibility.network-controllercreateWalletMiddleware.requestinRpcServiceRequestableandRpcServiceChainwere updated to match the same method inRpcService(and the change toRpcServiceRequestablewas marked as breaking).References
Progresses #6327.
Checklist
Note
Adds providerAsMiddlewareV2, deprecates OriginalRequest, and updates RPC request types to require Readonly/frozen JSON-RPC requests; tightens inflight-cache typings.
providerAsMiddlewareV2to convert anInternalProviderto v2 middleware.JsonRpcEngineV2and updatedcreateWalletMiddlewarehook signatures.inflight-cachetypes: useReadonly<Json>for results,unknownfor errors, and remove unnecessary casts.OriginalRequestas a deprecated alias ofMessageRequestin code and changelog.requestsignatures inRpcServiceRequestable/RpcServiceChainnow acceptReadonly<JsonRpcRequest<...>>(frozen requests); reflected in changelog.Written by Cursor Bugbot for commit ca59fe6. This will update automatically on new commits. Configure here.