Skip to content

Follow up to eth-json-rpc-middleware rewrite PR - #7138

Merged
mcmire merged 1 commit into
mainfrom
ejrpc-rewrite-followups
Nov 19, 2025
Merged

mcmire merged 1 commit into
mainfrom
ejrpc-rewrite-followups

Conversation

@mcmire

@mcmire mcmire commented Nov 12, 2025 •

Copy link
Copy Markdown
Collaborator

Explanation

The following changes extend c26899a:

  • eth-json-rpc-middleware
    • There were some unnecessary type assertions in inflight-cache.ts that have been removed.
  • message-manager
    • The rename of OriginalRequest introduced a breaking change. We don't strictly need to do this now, so we keep the old type around for backward compatibility.
  • network-controller
    • The changelog has been updated to mention that a new export was added, and to detail more changes to createWalletMiddleware.
    • The signatures of request in RpcServiceRequestable and RpcServiceChain were updated to match the same method in RpcService (and the change to RpcServiceRequestable was marked as breaking).

References

Progresses #6327.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Adds providerAsMiddlewareV2, deprecates OriginalRequest, and updates RPC request types to require Readonly/frozen JSON-RPC requests; tightens inflight-cache typings.

  • eth-json-rpc-middleware:
    • Added: providerAsMiddlewareV2 to convert an InternalProvider to v2 middleware.
    • Changed: Changelog clarifies migration to JsonRpcEngineV2 and updated createWalletMiddleware hook signatures.
    • Tighten inflight-cache types: use Readonly<Json> for results, unknown for errors, and remove unnecessary casts.
  • message-manager:
    • Changed/Deprecated: Keep OriginalRequest as a deprecated alias of MessageRequest in code and changelog.
  • network-controller:
    • BREAKING: request signatures in RpcServiceRequestable/RpcServiceChain now accept Readonly<JsonRpcRequest<...>> (frozen requests); reflected in changelog.

Written by Cursor Bugbot for commit ca59fe6. This will update automatically on new commits. Configure here.

The following changes extend
c26899a:

- `eth-json-rpc-middleware`
  - There were some unnecessary type assertions in `inflight-cache.ts`
    that have been removed.
- `message-manager`
  - The rename of `OriginalRequest` introduced a breaking change.
    We don't strictly need to do this now, so we keep the old type
    around for backward compatibility.
- `network-controller`
  - The changelog has been updated to mention that a new export was
    added, and to detail more changes to `createWalletMiddleware`.
  - The signatures of `request` in `RpcServiceRequestable` and
    `RpcServiceChain` were updated to match the same method in
    `RpcService` (and the change to `RpcServiceRequestable` was marked
    as breaking).
@mcmire
mcmire force-pushed the ejrpc-rewrite-followups branch from bc11646 to ca59fe6 Compare November 12, 2025 19:10
@mcmire
mcmire marked this pull request as ready for review November 12, 2025 19:16
@mcmire
mcmire requested review from a team as code owners November 12, 2025 19:16

@Gudahtt Gudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire
mcmire enabled auto-merge November 18, 2025 20:27
@mcmire
mcmire disabled auto-merge November 18, 2025 20:27
@mcmire
mcmire added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 2c96855 Nov 19, 2025
274 checks passed
@mcmire
mcmire deleted the ejrpc-rewrite-followups branch November 19, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants