feat: add last subscription response - #7110
Merged
Merged
Conversation
tuna1207
marked this pull request as ready for review
November 11, 2025 09:43
There was a problem hiding this comment.
Bug: State Log Snapshot Mismatch with Metadata (Bugbot Rules)
The test snapshot for includeInStateLogs still includes subscriptions in the expected output, but the metadata was changed to set includeInStateLogs: false for subscriptions. This will cause the test to fail since the snapshot expects subscriptions to be present but the metadata now excludes it from state logs. The snapshot needs updating to match the new metadata configuration.
packages/subscription-controller/src/SubscriptionController.test.ts#L1073-L1082
core/packages/subscription-controller/src/SubscriptionController.test.ts
Lines 1073 to 1082 in 0cfbd57
chaitanyapotti
approved these changes
Nov 11, 2025
lwin-kyaw
approved these changes
Nov 11, 2025
Member
Author
|
@metamaskbot publish-preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add last subscription response in getSubscriptions method
References
Checklist
Note
Adds
lastSubscriptionto controller state andgetSubscriptionsresponse, updates comparison/update logic and metadata, extendsSubscriptionfields, and updates tests/changelog.lastSubscriptiontoSubscriptionControllerStateand wire intogetSubscriptions(fetch, compare, persist, expose to UI).#isSubscriptionEqualand reuse in#areSubscriptionsEqual; update state only whenlastSubscription/subscriptions/trialedProducts/customerIdchange.subscriptions.includeInStateLogs→false; addpersist/usedInUiflags; add metadata forlastSubscription.GetSubscriptionsResponsewithlastSubscription.SubscriptionwithcanceledAt,inactiveAt, and requiredisEligibleForSupport.isEligibleForSupport.lastSubscriptionstate update; adjust snapshots for metadata changes.lastSubscriptionaddition.Written by Cursor Bugbot for commit d9c1f29. This will update automatically on new commits. Configure here.