Skip to content

feat: add infura supported networks #6972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
salimtb merged 18 commits into from
Oct 29, 2025
Merged

feat: add infura supported networks #6972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
72dec2b
feat: add infura supported networks
salimtb Oct 27, 2025
e644624
fix: add changelog
salimtb Oct 27, 2025
589fd90
fix: add changelog
salimtb Oct 27, 2025
618764d
fix: add changelog
salimtb Oct 27, 2025
60f872e
fix: fix unit tests
salimtb Oct 27, 2025
d4dd6a3
fix: fix changelog
salimtb Oct 27, 2025
72188d8
fix: fix changelog
salimtb Oct 27, 2025
25e3ef5
fix: fix changelog
salimtb Oct 27, 2025
00bf534
fix: fix cursor comment
salimtb Oct 27, 2025
eea603c
fix: fix test
salimtb Oct 27, 2025
f26c3c4
fix: clean up
salimtb Oct 28, 2025
ff8f151
fix: clean up
salimtb Oct 28, 2025
4e8cdc7
fix: fix linter
salimtb Oct 29, 2025
3f82040
Merge branch 'main' into feat/add-infura-networks
salimtb Oct 29, 2025
6dc6243
fix: fix tests
salimtb Oct 29, 2025
624a9ca
fix: fix PR comments
salimtb Oct 29, 2025
e0bbdc7
fix: clean changelog
salimtb Oct 29, 2025
fea7391
Merge branch 'main' into feat/add-infura-networks
salimtb Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/assets-controllers/src/TokenDetectionController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,7 +1181,18 @@ describe('TokenDetectionController', () => {
await advanceTime({ clock, duration: 1 });

expect(mockTokens).toHaveBeenNthCalledWith(1, {
chainIds: ['0x1', '0xaa36a7', '0xe705', '0xe708', '0x2105'],
chainIds: [
'0x1',
'0xaa36a7',
'0xe705',
'0xe708',
'0x2105',
'0xa4b1',
'0x38',
'0xa',
'0x89',
'0x531',
],
selectedAddress: secondSelectedAccount.address,
});
},
Expand Down
11 changes: 11 additions & 0 deletions packages/controller-utils/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Arbitrum, BSC, Optimism, Polygon, and Sei networks to Infura networks ([#6972](https://github.com/MetaMask/core/pull/6972))

@Prithpal-Sooriya Prithpal-Sooriya Oct 29, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mark this as a breaking change?
Technically this is an addition, however I remember adding base-mainnet as a default network caused cascading changes on other controllers/clients.

@mcmire mcmire Oct 29, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that these changes look innocuous. Also these changes make it so that these can be used as default networks but don't change the set of default networks themselves. I would expect that we would do that by changing network-controller. Do we anticipate also doing that in a separate PR?

That said, if have concerns, perhaps we could confirm by publishing a preview build and updating the clients as a preemptive measure?

@salimtb salimtb Oct 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcmire this has been tested on the client side already , a PR for it has been merged MetaMask/metamask-extension#37172 using a patch , it was test by QA and all works as expected
let me know if this answer your concerns

@salimtb salimtb Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we applied a patch since core releases was blocked, and we needed this change to be included in the current release cut.

@mcmire mcmire Oct 29, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh perfect, okay, no problem then!

- Add `arbitrum-one`, `bsc-mainnet`, `optimism-mainnet`, `polygon-mainnet`, `sei-mainnet` to `BUILT_IN_NETWORKS`
- Add `arbitrum-one`, `bsc-mainnet`, `optimism-mainnet`, `polygon-mainnet`, `sei-mainnet` to `InfuraNetworkType`
- Add `ArbitrumOne`, `BscMainnet`, `OptimismMainnet`, `PolygonMainnet`, `SeiMainnet` to `BuiltInNetworkName` enum
- Add corresponding chain IDs to `ChainId` type (0xa4b1, 0x38, 0xa, 0x89, 0x531)
- Add `ETG`, `BNB`, `ETH`, `POL`, `SEI` tickers to `NetworksTicker` enum
- Add block explorer URLs to `BlockExplorerUrl` quasi-enum
- Add network nicknames to `NetworkNickname` quasi-enum

## [11.14.1]

### Changed
Expand Down
35 changes: 35 additions & 0 deletions packages/controller-utils/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,41 @@ export const BUILT_IN_NETWORKS = {
blockExplorerUrl: BlockExplorerUrl['base-mainnet'],
},
},
[NetworkType['arbitrum-mainnet']]: {
chainId: ChainId['arbitrum-mainnet'],
ticker: NetworksTicker['arbitrum-mainnet'],
rpcPrefs: {
blockExplorerUrl: BlockExplorerUrl['arbitrum-mainnet'],
},
},
[NetworkType['bsc-mainnet']]: {
chainId: ChainId['bsc-mainnet'],
ticker: NetworksTicker['bsc-mainnet'],
rpcPrefs: {
blockExplorerUrl: BlockExplorerUrl['bsc-mainnet'],
},
},
[NetworkType['optimism-mainnet']]: {
chainId: ChainId['optimism-mainnet'],
ticker: NetworksTicker['optimism-mainnet'],
rpcPrefs: {
blockExplorerUrl: BlockExplorerUrl['optimism-mainnet'],
},
},
[NetworkType['polygon-mainnet']]: {
chainId: ChainId['polygon-mainnet'],
ticker: NetworksTicker['polygon-mainnet'],
rpcPrefs: {
blockExplorerUrl: BlockExplorerUrl['polygon-mainnet'],
},
},
[NetworkType['sei-mainnet']]: {
chainId: ChainId['sei-mainnet'],
ticker: NetworksTicker['sei-mainnet'],
rpcPrefs: {
blockExplorerUrl: BlockExplorerUrl['sei-mainnet'],
},
},
[NetworkType.rpc]: {
chainId: undefined,
blockExplorerUrl: undefined,
Expand Down
32 changes: 32 additions & 0 deletions packages/controller-utils/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ export const InfuraNetworkType = {
'linea-sepolia': 'linea-sepolia',
'linea-mainnet': 'linea-mainnet',
'base-mainnet': 'base-mainnet',
'arbitrum-mainnet': 'arbitrum-mainnet',
'bsc-mainnet': 'bsc-mainnet',
'optimism-mainnet': 'optimism-mainnet',
'polygon-mainnet': 'polygon-mainnet',
'sei-mainnet': 'sei-mainnet',
} as const;

export type InfuraNetworkType =
Expand Down Expand Up @@ -80,6 +85,11 @@ export enum BuiltInNetworkName {
MegaETHTestnet = 'megaeth-testnet',
MonadTestnet = 'monad-testnet',
BaseMainnet = 'base-mainnet',
ArbitrumOne = 'arbitrum-mainnet',
BscMainnet = 'bsc-mainnet',
OptimismMainnet = 'optimism-mainnet',
PolygonMainnet = 'polygon-mainnet',
SeiMainnet = 'sei-mainnet',
}

/**
Expand All @@ -98,6 +108,11 @@ export const ChainId = {
[BuiltInNetworkName.MegaETHTestnet]: '0x18c6', // toHex(6342)
[BuiltInNetworkName.MonadTestnet]: '0x279f', // toHex(10143)
[BuiltInNetworkName.BaseMainnet]: '0x2105', // toHex(8453)
[BuiltInNetworkName.ArbitrumOne]: '0xa4b1', // toHex(42161)
[BuiltInNetworkName.BscMainnet]: '0x38', // toHex(56)
[BuiltInNetworkName.OptimismMainnet]: '0xa', // toHex(10)
[BuiltInNetworkName.PolygonMainnet]: '0x89', // toHex(137)
[BuiltInNetworkName.SeiMainnet]: '0x531', // toHex(1329)
} as const;
export type ChainId = (typeof ChainId)[keyof typeof ChainId];

Expand All @@ -114,6 +129,13 @@ export enum NetworksTicker {
'monad-testnet' = 'MON',
// eslint-disable-next-line @typescript-eslint/no-duplicate-enum-values
'base-mainnet' = 'ETH',
// eslint-disable-next-line @typescript-eslint/no-duplicate-enum-values

@mcmire mcmire Oct 29, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, this rule is not very useful, is it. I will look into disabling this.

@salimtb salimtb Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this , i don't think it's really useful actually

'arbitrum-mainnet' = 'ETH',
'bsc-mainnet' = 'BNB',
// eslint-disable-next-line @typescript-eslint/no-duplicate-enum-values
'optimism-mainnet' = 'ETH',
'polygon-mainnet' = 'POL',
'sei-mainnet' = 'SEI',
rpc = '',
}

Expand All @@ -127,6 +149,11 @@ export const BlockExplorerUrl = {
[BuiltInNetworkName.MegaETHTestnet]: 'https://megaexplorer.xyz',
[BuiltInNetworkName.MonadTestnet]: 'https://testnet.monadexplorer.com',
[BuiltInNetworkName.BaseMainnet]: 'https://basescan.org',
[BuiltInNetworkName.ArbitrumOne]: 'https://arbiscan.io',
[BuiltInNetworkName.BscMainnet]: 'https://bscscan.com',
[BuiltInNetworkName.OptimismMainnet]: 'https://optimistic.etherscan.io',
[BuiltInNetworkName.PolygonMainnet]: 'https://polygonscan.com',
[BuiltInNetworkName.SeiMainnet]: 'https://seitrace.com',
} as const satisfies Record<BuiltInNetworkType, string>;
export type BlockExplorerUrl =
(typeof BlockExplorerUrl)[keyof typeof BlockExplorerUrl];
Expand All @@ -141,6 +168,11 @@ export const NetworkNickname = {
[BuiltInNetworkName.MegaETHTestnet]: 'Mega Testnet',
[BuiltInNetworkName.MonadTestnet]: 'Monad Testnet',
[BuiltInNetworkName.BaseMainnet]: 'Base Mainnet',
[BuiltInNetworkName.ArbitrumOne]: 'Arbitrum One',
[BuiltInNetworkName.BscMainnet]: 'BSC Mainnet',
[BuiltInNetworkName.OptimismMainnet]: 'Optimism Mainnet',
[BuiltInNetworkName.PolygonMainnet]: 'Polygon Mainnet',
[BuiltInNetworkName.SeiMainnet]: 'Sei Mainnet',
} as const satisfies Record<BuiltInNetworkType, string>;
export type NetworkNickname =
(typeof NetworkNickname)[keyof typeof NetworkNickname];
Expand Down
Loading
Loading