Repository navigation
(SWAPS3309): Replace noFee bridge api parameter with fee. - #6964
Merged
Merged
Conversation
micaelae
previously approved these changes
Oct 28, 2025
ChingizMardanov
marked this pull request as ready for review
October 29, 2025 18:03
bfullam
previously approved these changes
Oct 29, 2025
ChingizMardanov
dismissed stale reviews from bfullam and micaelae
via
October 30, 2025 13:30
c9fae63
ChingizMardanov
enabled auto-merge (squash)
October 30, 2025 17:40
bfullam
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Bridge API used to have a
noFeeparameter that was changed tofeeparameter. For some time api will support both, however to eventually sunset a less flexiblenoFeeparameter controller had to be changed.References
Associated bridge-api PR.
Checklist
Note
Switches bridge request parameter from boolean
noFeeto numericfeeand updates types, validators, fetch utils, tests, and changelog.noFeewithfeeacross request handling and feature overrides.QuoteRequesttofee?: number(removenoFee).GenericQuoteRequestSchematofeeand associated enums/schemas.feeinstead ofnoFeeinformatQueryParams(fetch.ts).FeatureId.PERPSnow injectfeeand preserveaggIds/bridgeIdsinfetchQuotes.feeand verifyfee=0in request URLs.Written by Cursor Bugbot for commit d0285e8. This will update automatically on new commits. Configure here.