Conversation
matthewwalsh0
added a commit
that referenced
this pull request
Nov 13, 2025
## Explanation Always get a quote if using the Relay strategy and the required token is Arbitrum USDC, even if the payment token matches. ## References Related to [#6247](MetaMask/MetaMask-planning#6247) ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Always retrieve a Relay quote for Arbitrum USDC deposits and convert getStrategy from async to sync across controller, utils, and tests. > > - **Behavior Change (Relay + Arbitrum USDC)** > - In `utils/source-amounts.ts`, always require a quote when strategy is `Relay` and required token is Arbitrum USDC, even if the payment token matches (via `isQuoteAlwaysRequired`). > - **API/Contract Change (BREAKING)** > - `getStrategy` constructor option and action changed from async to sync. > - Updated handler registration in `TransactionPayController.ts` and all call sites to remove `await` (e.g., `utils/strategy.ts`, `utils/quotes.ts`, `helpers/TransactionPayPublishHook.ts`). > - **Tests** > - Adjusted tests to reflect synchronous `getStrategy` and new behavior for Arbitrum USDC with Relay. > - **Changelog** > - Documented breaking change and new Relay quote behavior. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit a5261e83340d02e90a7ffb43a52861fc9836a801. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
When running
yarn mm-foundryup install --version=stablethis fails.It checks if it is a valid version string starting with
'v'or'nightly'. But both nightly and stable are valid tags. This logic should be changed to includestable.References
To match the existing behavior of
foundryup --install stable.Fixes #6245
Changelog
Checklist