Repository navigation
chore: bump keyring packages - #5405
Merged
Merged
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
Have feedback? Participate in our User Experience Survey 📊 |
mikesposito
commented
Feb 27, 2025
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mikesposito
commented
Mar 3, 2025
|
|
||
| ## [19.2.1] | ||
|
|
||
| ### Changed |
Member
Author
There was a problem hiding this comment.
There are some changelog entries that have been misplaced: they are under 19.2.1 but they are actually unreleased
mikesposito
marked this pull request as ready for review
March 3, 2025 10:01
matthewwalsh0
approved these changes
Mar 3, 2025
ccharly
approved these changes
Mar 3, 2025
mikesposito
commented
Mar 3, 2025
Comment on lines
-2462
to
+2434
| // @ts-expect-error Enforce data type after updating clients | ||
| await keyring.deserialize(data); | ||
| if (data) { | ||
| // @ts-expect-error Enforce data type after updating clients | ||
| await keyring.deserialize(data); | ||
| } |
Member
Author
There was a problem hiding this comment.
Just want to make sure that this gets noticed: KeyringController now doesn't call keyring.deserialize if there's no data to pass
Contributor
There was a problem hiding this comment.
I did saw it, and I think that actually make sense that way too. :)
mathieuartu
approved these changes
Mar 3, 2025
7 tasks
sahar-fehri
approved these changes
Mar 3, 2025
github-merge-queue Bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 7, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> These packages are being bumped to their latest version: ### `@metamask/keyring-controller` - **BREAKING:** `addNewKeyring` method now returns `Promise<KeyringMetadata>` instead of `Promise<unknown>` ([#5372](MetaMask/core#5372)) - Consumers can use the returned `KeyringMetadata.id` to access the created keyring instance via `withKeyring`. - **BREAKING:** `withKeyring` method now requires a callback argument of type `({ keyring: SelectedKeyring; metadata: KeyringMetadata }) => Promise<CallbackResult>` ([#5372](MetaMask/core#5372)) - Bump `@metamask/keyring-internal-api` from `^4.0.3` to `^5.0.0` ([#5405](MetaMask/core#5405)) - Bump `@metamask/eth-hd-keyring` from `^10.0.0` to `^11.0.0` ([#5405](MetaMask/core#5405)) - Bump `@metamask/eth-simple-keyring` from `^8.1.0` to `^9.0.0` ([#5405](MetaMask/core#5405)) ### `@metamask/profile-sync-controller` - Bump `@metamask/keyring-internal-api` from `^4.0.3` to `^5.0.0` ([#5405](MetaMask/core#5405)) ### `@metamask/eth-ledger-bridge-keyring` - **BREAKING:** `LedgerKeyring` now implements the `Keyring` type ([#194](MetaMask/accounts#194)) - The class does not extend `EventEmitter` anymore. - The `LedgerKeyring.accounts` class variable is now a `readonly Hex[]` array. - The `addAccounts` method signature has been changed: - An `amount` number parameter is now required to specify the number of accounts to add. - The method now returns a promise resolving to an array of `Hex` addresses. - The `unlock` method now returns `Promise<Hex>`. - The `getAccounts` method now returns `Promise<Hex[]>`. - The `deserialize` method now requires a `LedgerKeyringSerializedState` typed parameter. - The `signTransaction` method now accepts an `Hex` typed value as the `address` parameter. - The `signMessage` method now accepts an `Hex` typed value as the `withAccount` parameter. - The `signPersonalMessage` method now accepts an `Hex` typed value as the `withAccount` parameter. - The `signTypedData` method now accepts an `Hex` typed value as the `withAccount` parameter. - The `unlockAccountByAddress` method now accepts an `Hex` typed value as the `address` parameter. [](https://codespaces.new/MetaMask/metamask-extension/pull/30637?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
](https://codespaces.new/MetaMask/metamask-extension/pull/30637?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR bumps these packages across the core controllers:
@metamask/eth-simple-keyring@metamask/eth-hd-keyring@metamask/keyring-internal-apiThe package is being updated on Extension by this PR: MetaMask/metamask-extension#30637
References
Changelog
@metamask/keyring-controller@metamask/eth-simple-keyringfrom^8.1.0to^9.0.0(#5405)@metamask/eth-hd-keyringfrom^10.0.0to^11.0.0(#5405)@metamask/keyring-internal-apifrom^4.0.3to^5.0.0(#5405)@metamask/accounts-controller@metamask/keyring-internal-apifrom^4.0.3to^5.0.0(#5405)@metamask/profile-sync-controller@metamask/keyring-internal-apifrom^4.0.3to^5.0.0(#5405)@metamask/assets-controller@metamask/keyring-internal-apifrom^4.0.3to^5.0.0(#5405)@metamask/multichain-transaction-controller@metamask/keyring-internal-apifrom^4.0.3to^5.0.0(#5405)Checklist