Repository navigation
chore(keyring-controller): deprecate QR Keyring methods - #4365
Merged
Merged
Conversation
ccharly
reviewed
Jun 5, 2024
ccharly
left a comment
ccharly
left a comment
Contributor
There was a problem hiding this comment.
Nitpick: Mostly cosmetic suggestions to match with other comments (feel free to ignore them!) 😃
Contributor
|
Nitpick (again 🙈): The title could probably be named differently to match conv commits, something like |
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
mikesposito
changed the title
mcmire
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
With the introduction of
withKeyring,KeyringControllerprovides a solid alternative to QR-specific methods. This is a good chance to start moving away from them.This PR deprecates all QR-specific methods, to discourage further usage in clients and promotes
withKeyring.References
Related to #3786
Changelog
@metamask/keyring-controllerKeyringControllerChecklist