Repository navigation
Remove no-useless-escape lint rule - #417
Merged
Merged
Conversation
Gudahtt
reviewed
Mar 20, 2021
| const normalized = ensNamehash.normalize(ensName.trim()); | ||
| // this regex is only sufficient with the above call to ensNamehash.normalize | ||
| // TODO: change 7 in regex to 3 when shorter ENS domains are live | ||
| // eslint-disable-next-line require-unicode-regexp |
Member
There was a problem hiding this comment.
Nice! Always great to see these removed.
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Recent entries referenced the wrong PR number in the change entry. IT correctly linked #413 but the link text was mistakenly left as 404.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes one line that uses a "useless escape". I removed the escape character, as well as added the u flag, resolving two eslint issues. I then removed the disable for this rule in the eslint config.