Repository navigation
Lint .js files - #291
Merged
Merged
Lint .js files#291
Conversation
Merged
Merged
Mrtenz
pushed a commit
to Mrtenz/core
that referenced
this pull request
Jun 17, 2026
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Sep 13, 2026
## Summary
- Updates `action-npm-publish` from v5 to v6
- Adds `id-token: write` permission to `publish-release` job in
`main.yml`
- Adds `permissions` block to `publish-npm` job in `publish-release.yml`
- Makes `NPM_TOKEN` secret optional
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Changes the production npm release path and auth model (OIDC +
optional token); misconfiguration could block publishes or affect
first-time package setup.
>
> **Overview**
> Upgrades the release pipeline to **`MetaMask/action-npm-publish@v6`**
for both the dry-run and production npm publish jobs, matching v6’s
expected GitHub Actions setup.
>
> **OIDC / permissions:** The reusable `publish-release` invocation in
`main.yml` now grants **`id-token: write`**, and the **`publish-npm`**
job sets explicit permissions (`contents: read`, `id-token: write`) so
the action can authenticate without relying only on a long-lived token
where OIDC is supported.
>
> **Secrets contract:** `NPM_TOKEN` on the callable workflow is now
**optional** (`required: false`), and comments clarify it is only needed
for a **first-time** package publish; the dry-run step no longer
documents omitting `npm-token` explicitly. The real publish step still
passes `npm-token: ${{ secrets.NPM_TOKEN }}` when configured.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
9ae62d352b8c492e67e7fdfde8b23d71cf57306e. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We weren't linting or formatting
.jsfiles. This PR ensures that we are.