Repository navigation
Conversation
Gudahtt
requested changes
May 7, 2020
Member
There was a problem hiding this comment.
This doesn't affect consumers of this package, so I'm not sure it's worth mentioning.
Member
There was a problem hiding this comment.
We could probably remove this, since it's in v1.x
Contributor
Author
|
Mrtenz
pushed a commit
to Mrtenz/core
that referenced
this pull request
Jun 17, 2026
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Sep 13, 2026
…h proposal (MetaMask#227) Added full support for [CAIP-19 Asset IDs](https://github.com/ChainAgnostic/CAIPs/blob/main/CAIPs/caip-19.md) including the necessary regex, structs, and parsing functions. A few notes: - While the regex of a chain namespace is technically the same as an asset namespace, the official proposal makes a clear distinction between the two, and so it's within the spirit of the spec to break these out into separate properties. The same cannot be said for a chain reference vs asset reference: these require different regex for validation. - Previously, `CaipAssetId` required a tokenId (`/${string}`) to be present. This has been changed to allow for tokenId to be optional (as dictated by the official proposal) in both the type and its corresponding regex string - For completeness, `toCaipAccountId` and `parseCaipAssetId` functions were added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #204
This PR represents v2