Skip to content

Return tx errors correctly - #186

Merged
estebanmino merged 3 commits into
developfrom
fix-tx-error-swalloing
Dec 13, 2019
Merged

Return tx errors correctly#186
estebanmino merged 3 commits into
developfrom
fix-tx-error-swalloing

Conversation

@brunobar79

@brunobar79 brunobar79 commented Dec 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

We have seen a bunch of error like this one in mobile that looks like : "[object Object]

Screen Shot 2019-12-13 at 3 40 52 AM

This is the reason:

Screen Shot 2019-12-13 at 3 40 07 AM

This PR fixes the issue by passing the error object instead.

@brunobar79 brunobar79 changed the title Safely stringify error Safely stringify tx errors Dec 13, 2019
@codecov-io

codecov-io commented Dec 13, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #186 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #186   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           23     23           
  Lines         1515   1515           
  Branches       210    210           
======================================
  Hits          1515   1515
Impacted Files Coverage Δ
src/transaction/TransactionController.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873cf96...7c831bc. Read the comment docs.

@brunobar79 brunobar79 changed the title Safely stringify tx errors Return tx errors correctly Dec 13, 2019
estebanmino
estebanmino approved these changes Dec 13, 2019
View reviewed changes

@estebanmino estebanmino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@estebanmino
estebanmino merged commit 9125c22 into develop Dec 13, 2019
@estebanmino
estebanmino deleted the fix-tx-error-swalloing branch December 13, 2019 13:52
@brunobar79 brunobar79 mentioned this pull request Jan 7, 2020
Closed
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
@dependabot
Bump @metamask/eth-json-rpc-provider from 2.1.0 to 2.2.0 (#186)
93f19a3
Mrtenz pushed a commit that referenced this pull request Oct 16, 2025
@github-actions @Gudahtt
10.0.0 (#186)
4e13ec7 
* 10.0.0

* Update changelog

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Naz-Ovh pushed a commit to 0x-fork/metamask-core that referenced this pull request Sep 13, 2026
@MajorLift
Bump @metamask/superstruct from ^3.0.0 to ^3.1.0 (MetaMask#194)
01ce658 
- Closes MetaMask#186
Naz-Ovh pushed a commit to 0x-fork/metamask-core that referenced this pull request Nov 7, 2026
@Gudahtt
Fix typedSignatureHash documentation (MetaMask#186)
abda0c0 
The inline docs erroneously described this function as returning a type
hash for "V1" of `signTypedData`. But "V1" didn't include a type hash.
Rather, this function returns the hash of the entire message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@estebanmino estebanmino estebanmino approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@estebanmino estebanmino

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brunobar79 @codecov-io @estebanmino