Repository navigation
Fix typos in comments - #128
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #128 +/- ##
======================================
Coverage 100% 100%
======================================
Files 21 21
Lines 1432 1432
Branches 194 194
======================================
Hits 1432 1432
Continue to review full report at Codecov.
|
bitpshr
approved these changes
Jul 2, 2019
Naz-Ovh
pushed a commit
to 0x-fork/metamask-core
that referenced
this pull request
Sep 13, 2026
<!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? Are there any issues or other links reviewers should consult to understand this pull request better? For instance: * Fixes #12345 * See: #67890 --> The `deserialize` and `serialize` methods present wrong signatures as they expect the `State extends Json` generic type passed to the `Keyring` for their arguments and return value. They now present the following signatures: - `serialize(): Promise<Json>` - `deserialize(state: Json): Promise<void>` Since now the `State extends Json` generic is unused, it has been removed from the `Keyring` type * Fixes: MetaMask#128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few typos found throughout the comments.