Repository navigation
feat(profile-controller): fix x methods, api response type add fetchAndUpdateProfile - #10793
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b7c4fcc. Configure here.
hmalik88
changed the title
fetchAndUpdateProfilefetchAndUpdateProfile
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
ccharly
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
profileIdcheck in state for x methods that would throw since at the point that those methods are called, a profile should not exist in state. Removed that check.fetchAndUpdateProfilemethodnullablefromavatar_urlin the profile api response typeReferences
N/A
Checklist
Note
Medium Risk
X OAuth can run without local profile state and
connectedToXis no longer updated on connect;avatar_urlis now required in API responses, which may fail validation if the API still returns null.Overview
Adds
fetchAndUpdateProfileonProfileController, wired through the messenger toProfileService:getProfile, mapping the API response intostate.profilewithout touchingxProfile.Relaxes X OAuth entry points so
getXAuthorizationUrlandconnectXno longer require a profile in local state (removed#getProfileIdOrThrow()).connectXonly persistsxProfileon success; it no longer flipsprofile.connectedToXin state.Tightens profile API typing by making
avatar_urlnon-nullable inProfileServicevalidation and mapping it directly (drops null-to-empty handling and related tests).Reviewed by Cursor Bugbot for commit 2a6e9ee. Bugbot is set up for automated code reviews on this repo. Configure here.