[georgeweiler]

Explanation

hydrateVbaOnboarding registered the Money Account wallet and then always created a BRL → mUSD autoramp. After the standing BRL route, hosts need to finish signing and refresh autoramps without creating, then create one autoramp only for a fiat the caller passes in.

hydrateVbaOnboarding now takes an optional sourceCurrencyCode:

• No code, and no usable autoramp: return autorampStatus: 'needs_source_currency' and do not POST.
• A code, and no usable autoramp: create one autoramp whose source_currencies[0].code is that fiat. Destination stays mUSD on Monad. The idempotency key prefix follows the code (brl-musd-monad / usd-musd-monad), so a USD create does not replay the BRL route.
• A usable autoramp already exists for the wallet: return ready and do not create, even if a code was passed.

buildMusdAutorampRequest builds that body for an explicit code. buildBrazilMusdAutorampRequest remains the BRL wrapper. NeoBankService.createAutoramp is unchanged; it already forwards the body.

This is a behavior change for callers that relied on hydrate to create the BRL autoramp. Those callers must pass sourceCurrencyCode: 'BRL' on the call that should create. Mobile adoption is not in this pull request.

References

• Builds on feat(ramps-controller): create a BRL to mUSD autoramp for Money Account #10586

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

  

[wenfix]

Non-blocking review — no blocking issues found. Logic checks out: the needs_source_currency early return sits after wallet registration and the autoramp refresh, whitespace-only codes are treated as omitted, the idempotency key change only alters the prefix, and nothing iterates VBA_AUTORAMP_STATUSES positionally. Verified: all 1052 tests in @metamask/ramps-controller pass and yarn changelog:validate passes. Three minor observations below.

[wenfix]

Non-blocking: the code is normalized (trimmed + lowercased) for the idempotency key but goes into source_currencies[0].code verbatim. So sourceCurrencyCode: 'usd' and 'USD' produce the same idempotency key with different bodies — the first create wins, and a later correctly-cased retry would be deduplicated against it. This only matters if a caller passes non-canonical casing (every current call site and doc example uses uppercase), and I can't tell from this repo whether MoonPay is case-sensitive on source_currencies[].code. Normalizing to uppercase (or validating against a supported list) at this boundary would remove the ambiguity.

[wenfix]

Non-blocking (and already documented here) — flagging so the consuming host behavior gets confirmed: when an in-flight run started without a code, a call that passes sourceCurrencyCode joins that run, receives needs_source_currency, and no create is scheduled. If a host polls this on a timer without a code, a user action that passes a code can silently no-op and must be retried. The host has to treat needs_source_currency after passing a code as a retry signal, since it cannot distinguish this case from the legitimate nothing-passed case.

[wenfix]

Non-blocking: this not.toBe assertion is strictly weaker than the toHaveBeenCalledWith above it, which already asserts the full usd-musd-monad:customer-1:0xabc key — so this line adds no coverage. If you want the test tighter, both it and the idempotencyKey extraction can be dropped.