Repository navigation
fix(profile-sync-controller): coalesce concurrent performSignIn calls - #10646
Merged
Merged
Conversation
mathieuartu
changed the title
performSignIn calls
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
mathieuartu
changed the title
performSignIn callsperformSignIn calls
mathieuartu
enabled auto-merge
October 1, 2026 09:46
ccharly
approved these changes
Oct 1, 2026
Contributor
|
Removed from queue cause I was not sure if this was a fix or not, but we can amend that later or during the next release if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Changes concurrent behavior in the authentication sign-in path; coalescing is straightforward and covered by tests, but callers now share one in-flight outcome including errors.
Overview
AuthenticationController.performSignInnow deduplicates overlapping calls: a private#ongoingSignInpromise is shared by concurrent callers, and the previous sign-in body lives in#runPerformSignIn, which clears the slot infinallywhen that run finishes.That stops duplicate unlock/auto-sign-in triggers from running parallel full sign-in flows (multiple SRP logins and pairing). A new test asserts overlapping callers resolve to the same token array and a call after completion gets a new result. The unreleased changelog records the fix.
Reviewed by Cursor Bugbot for commit 576eebc. Bugbot is set up for automated code reviews on this repo. Configure here.