fix(money): remove raw amounts from error logging - #10619
Merged
Merged
Conversation
ffmcgee725
marked this pull request as ready for review
September 30, 2026 11:18
pull Bot
pushed a commit
to Reality2byte/core
that referenced
this pull request
Sep 30, 2026
## Explanation - Patch release of `@metamask/money-account-balance-service` to `3.1.2`. - Stop including balance amounts in `MoneyAccountBalanceValidationError` messages, which are reported via the messenger's `captureException` (MetaMask#10619). `@metamask/subscription-controller` now depends on `@metamask/money-account-balance-service` `^3.1.2` so the workspace dependency range matches the package being released. That package is not version-bumped. ## References * MetaMask#10619 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them Made with [Cursor](https://cursor.com) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
4 of 7 tasks
LabinatorSolutions
pushed a commit
to LabinatorSolutions/metamask-extension
that referenced
this pull request
Sep 30, 2026
…6815) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** `@metamask/money-account-balance-service` 3.1.1 put raw balance amounts into `MoneyAccountBalanceValidationError` messages, and those errors are reported through `captureException`. Exact balances can identify an account. The extension masked those amounts in `beforeSend` as a stopgap. [core#10619](MetaMask/core#10619), released as `@metamask/money-account-balance-service` 3.1.2, stops interpolating the amounts. The messages now only say which check failed. This bumps the package to `^3.1.2` and removes the client-side balance scrubbing from `setupSentry`, restoring the address-only sanitizer. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Run the extension and open the Money Account home page. 2. Confirm a deposit or withdraw on Monad and verify the balance still refreshes after confirmation. 3. Confirm a Perps or Predict transfer paid with mUSD from the Money Account and verify that balance still refreshes. 4. There is no user-visible change to Sentry. The validation errors from the balance service no longer include balance amounts, so the extension no longer masks them locally. <!-- ## **Screenshots/Recordings** ### **Before** ### **After** --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
MoneyAccountBalanceValidationErrormessages.Changelog
@metamask/money-account-balance-service
[Unreleased]
Fixed
MoneyAccountBalanceValidationErrormessages, which are reported via the messenger'scaptureException(#10619)