Repository navigation
fix(core-backend): price supportedNetwork response - #10582
Merged
Merged
Conversation
Kriys94
force-pushed
the
fix/SupportedNetworkPrice
branch
from
September 29, 2026 20:16
28fb1f8 to
65f9685
Compare
Kriys94
marked this pull request as ready for review
September 30, 2026 07:46
Prithpal-Sooriya
previously approved these changes
Sep 30, 2026
Comment on lines
+93
to
+96
| partialSupport: { | ||
| spotPricesV2: [], | ||
| spotPricesV3: partialSupportNetworks, | ||
| }, |
Contributor
There was a problem hiding this comment.
lol I remember now 😄
Prithpal-Sooriya
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Medium Risk
Breaking TypeScript shape for supported-networks responses affects downstream consumers, while the PriceDataSource fix changes which chains get v3 price requests (restores pricing on v3-partial networks, avoids incorrect inclusion from v2-only lists).
Overview
Aligns core-backend Price API types with the real
/v1and/v2/supportedNetworkspayloads:partialSupportis no longer a flatstring[]but an object keyed by spot-price endpoint (spotPricesV2, and for v2 alsospotPricesV3). AddsPriceV1SupportedNetworksResponseandPriceV2SupportedNetworksResponse, wires them throughPricesApiClient, exports, tests, and README;PriceSupportedNetworksResponseis deprecated (still aliased to the v2 type for compatibility).PriceDataSourceno longer treats object-shapedpartialSupportlike an array when building the supported-chain set for/v3/spot-prices. It now usesfullSupport+partialSupport.spotPricesV3, ignores v2-only partial chains, and still accepts a legacy array-shapedpartialSupportas a fallback. Tests and mocks were updated accordingly (including human-readable balance fixtures in price tests).Reviewed by Cursor Bugbot for commit a3de066. Bugbot is set up for automated code reviews on this repo. Configure here.