Skip to content

fix(core-backend): price supportedNetwork response - #10582

Merged
Kriys94 merged 2 commits into
mainfrom
fix/SupportedNetworkPrice
Sep 30, 2026
Merged

Kriys94 merged 2 commits into
mainfrom
fix/SupportedNetworkPrice

Conversation

@Kriys94

@Kriys94 Kriys94 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Breaking TypeScript shape for supported-networks responses affects downstream consumers, while the PriceDataSource fix changes which chains get v3 price requests (restores pricing on v3-partial networks, avoids incorrect inclusion from v2-only lists).

Overview
Aligns core-backend Price API types with the real /v1 and /v2/supportedNetworks payloads: partialSupport is no longer a flat string[] but an object keyed by spot-price endpoint (spotPricesV2, and for v2 also spotPricesV3). Adds PriceV1SupportedNetworksResponse and PriceV2SupportedNetworksResponse, wires them through PricesApiClient, exports, tests, and README; PriceSupportedNetworksResponse is deprecated (still aliased to the v2 type for compatibility).

PriceDataSource no longer treats object-shaped partialSupport like an array when building the supported-chain set for /v3/spot-prices. It now uses fullSupport + partialSupport.spotPricesV3, ignores v2-only partial chains, and still accepts a legacy array-shaped partialSupport as a fallback. Tests and mocks were updated accordingly (including human-readable balance fixtures in price tests).

Reviewed by Cursor Bugbot for commit a3de066. Bugbot is set up for automated code reviews on this repo. Configure here.

@Kriys94
Kriys94 force-pushed the fix/SupportedNetworkPrice branch from 28fb1f8 to 65f9685 Compare September 29, 2026 20:16
@Kriys94
Kriys94 marked this pull request as ready for review September 30, 2026 07:46
@Kriys94
Kriys94 requested review from a team as code owners September 30, 2026 07:46
@Kriys94
Kriys94 deployed to default-branch September 30, 2026 07:46 — with GitHub Actions Active
Comment on lines +93 to +96
partialSupport: {
spotPricesV2: [],
spotPricesV3: partialSupportNetworks,
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol I remember now 😄

@Kriys94
Kriys94 added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit cb3db79 Sep 30, 2026
121 checks passed
@Kriys94
Kriys94 deleted the fix/SupportedNetworkPrice branch September 30, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants