fix(assets-controller): clean v5 native balance state update by Kriys94 · Pull Request #10567 · MetaMask/core

Kriys94 · 2026-09-29T12:01:06Z

Explanation

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Kriys94 · 2026-09-29T12:07:34Z

@metamaskbot publish-preview

github-actions · 2026-09-29T12:13:55Z

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.

@metamask-previews/account-tree-controller@11.0.0-preview-3556501b4
@metamask-previews/accounts-controller@40.0.0-preview-3556501b4
@metamask-previews/address-book-controller@8.0.0-preview-3556501b4
@metamask-previews/advanced-chart-core@0.0.0-preview-3556501b4
@metamask-previews/ai-controllers@2.0.0-preview-3556501b4
@metamask-previews/analytics-controller@3.2.0-preview-3556501b4
@metamask-previews/analytics-data-regulation-controller@0.0.0-preview-3556501b4
@metamask-previews/announcement-controller@9.0.0-preview-3556501b4
@metamask-previews/app-metadata-controller@3.0.0-preview-3556501b4
@metamask-previews/approval-controller@10.0.0-preview-3556501b4
@metamask-previews/assets-controller@17.0.0-preview-3556501b4
@metamask-previews/assets-controllers@112.0.4-preview-3556501b4
@metamask-previews/authenticated-user-storage@4.1.0-preview-3556501b4
@metamask-previews/base-controller@10.0.0-preview-3556501b4
@metamask-previews/base-data-service@2.1.0-preview-3556501b4
@metamask-previews/bitcoin-regtest-up@2.0.0-preview-3556501b4
@metamask-previews/bridge-controller@81.3.3-preview-3556501b4
@metamask-previews/bridge-status-controller@76.3.3-preview-3556501b4
@metamask-previews/build-utils@4.0.0-preview-3556501b4
@metamask-previews/chain-agnostic-permission@2.0.0-preview-3556501b4
@metamask-previews/chomp-api-service@6.0.0-preview-3556501b4
@metamask-previews/claims-controller@1.0.2-preview-3556501b4
@metamask-previews/client-controller@2.0.0-preview-3556501b4
@metamask-previews/client-utils@3.0.3-preview-3556501b4
@metamask-previews/compliance-controller@3.0.0-preview-3556501b4
@metamask-previews/composable-controller@13.0.0-preview-3556501b4
@metamask-previews/config-registry-controller@4.0.0-preview-3556501b4
@metamask-previews/connectivity-controller@1.0.0-preview-3556501b4
@metamask-previews/controller-utils@13.0.0-preview-3556501b4
@metamask-previews/core-backend@11.0.0-preview-3556501b4
@metamask-previews/cryptography@0.0.0-preview-3556501b4
@metamask-previews/delegation-controller@4.0.0-preview-3556501b4
@metamask-previews/earn-controller@13.0.2-preview-3556501b4
@metamask-previews/eip-5792-middleware@4.0.1-preview-3556501b4
@metamask-previews/eip-7702-internal-rpc-middleware@1.0.0-preview-3556501b4
@metamask-previews/eip1193-permission-middleware@3.0.0-preview-3556501b4
@metamask-previews/eth-block-tracker@16.0.0-preview-3556501b4
@metamask-previews/eth-json-rpc-middleware@25.0.0-preview-3556501b4
@metamask-previews/eth-json-rpc-provider@7.0.0-preview-3556501b4
@metamask-previews/foundryup@2.0.0-preview-3556501b4
@metamask-previews/gas-fee-controller@27.0.0-preview-3556501b4
@metamask-previews/gator-permissions-controller@6.0.1-preview-3556501b4
@metamask-previews/geolocation-controller@2.0.0-preview-3556501b4
@metamask-previews/java-tron-up@2.0.0-preview-3556501b4
@metamask-previews/json-rpc-engine@11.0.0-preview-3556501b4
@metamask-previews/json-rpc-middleware-stream@9.0.0-preview-3556501b4
@metamask-previews/keyring-controller@28.1.0-preview-3556501b4
@metamask-previews/kyc-controller@0.6.0-preview-3556501b4
@metamask-previews/local-node-utils@2.0.0-preview-3556501b4
@metamask-previews/logging-controller@10.0.0-preview-3556501b4
@metamask-previews/message-manager@15.0.0-preview-3556501b4
@metamask-previews/messenger@3.0.0-preview-3556501b4
@metamask-previews/messenger-cli@1.0.0-preview-3556501b4
@metamask-previews/money-account-api-data-service@2.0.0-preview-3556501b4
@metamask-previews/money-account-balance-service@3.1.0-preview-3556501b4
@metamask-previews/money-account-controller@2.0.0-preview-3556501b4
@metamask-previews/money-account-upgrade-controller@5.1.0-preview-3556501b4
@metamask-previews/money-account-utils@2.1.0-preview-3556501b4
@metamask-previews/multichain-account-service@14.1.0-preview-3556501b4
@metamask-previews/multichain-api-middleware@5.0.0-preview-3556501b4
@metamask-previews/multichain-network-controller@4.0.0-preview-3556501b4
@metamask-previews/multichain-transactions-controller@8.0.0-preview-3556501b4
@metamask-previews/name-controller@10.0.0-preview-3556501b4
@metamask-previews/network-connection-banner-controller@1.0.0-preview-3556501b4
@metamask-previews/network-controller@37.0.0-preview-3556501b4
@metamask-previews/network-enablement-controller@7.0.1-preview-3556501b4
@metamask-previews/notification-services-controller@29.0.2-preview-3556501b4
@metamask-previews/passkey-controller@4.1.0-preview-3556501b4
@metamask-previews/permission-controller@14.0.0-preview-3556501b4
@metamask-previews/permission-log-controller@6.0.0-preview-3556501b4
@metamask-previews/perps-controller@18.0.1-preview-3556501b4
@metamask-previews/phishing-controller@18.1.1-preview-3556501b4
@metamask-previews/platform-api-docs@0.2.1-preview-3556501b4
@metamask-previews/polling-controller@17.0.0-preview-3556501b4
@metamask-previews/preferences-controller@24.0.0-preview-3556501b4
@metamask-previews/profile-metrics-controller@5.1.2-preview-3556501b4
@metamask-previews/profile-sync-controller@33.0.0-preview-3556501b4
@metamask-previews/ramps-controller@26.0.0-preview-3556501b4
@metamask-previews/rate-limit-controller@8.0.0-preview-3556501b4
@metamask-previews/react-data-query@2.0.0-preview-3556501b4
@metamask-previews/remote-feature-flag-controller@7.0.0-preview-3556501b4
@metamask-previews/sample-controllers@6.0.0-preview-3556501b4
@metamask-previews/seedless-onboarding-controller@11.0.1-preview-3556501b4
@metamask-previews/selected-network-controller@27.0.0-preview-3556501b4
@metamask-previews/sentinel-api-service@2.0.0-preview-3556501b4
@metamask-previews/shield-controller@7.0.3-preview-3556501b4
@metamask-previews/signature-controller@40.0.0-preview-3556501b4
@metamask-previews/smart-transactions-controller@27.0.3-preview-3556501b4
@metamask-previews/snap-account-service@4.0.0-preview-3556501b4
@metamask-previews/social-controllers@3.4.0-preview-3556501b4
@metamask-previews/solana-test-validator-up@2.0.0-preview-3556501b4
@metamask-previews/stellar-quickstart-up@0.0.0-preview-3556501b4
@metamask-previews/storage-service@2.0.0-preview-3556501b4
@metamask-previews/subscription-controller@10.0.1-preview-3556501b4
@metamask-previews/transaction-controller@72.0.1-preview-3556501b4
@metamask-previews/transaction-pay-controller@29.2.3-preview-3556501b4
@metamask-previews/user-operation-controller@42.0.1-preview-3556501b4
@metamask-previews/utils@12.0.0-preview-3556501b4
@metamask-previews/wallet@15.0.1-preview-3556501b4
@metamask-previews/wallet-cli@0.0.0-preview-3556501b4

Kriys94 · 2026-09-30T13:11:29Z

            const nativeAssetIdsForAccount = account
              ? this.#getNativeAssetIdsForAccount(account)
-              : this.#getNativeAssetIdsForEnabledChains();
+              : [];


The main fix and reason for this PR. The rest is mainly restoring the corrupted state. This logic will be gone with v6

Prithpal-Sooriya · 2026-09-30T13:33:05Z

Perfect! Nicely done!

fix(assets-controller): clean v5 native balance state update

3556501

Kriys94 force-pushed the fix/NativeAssetsUpdate branch from 1c107fb to 3556501 Compare September 29, 2026 12:06

Kriys94 mentioned this pull request Sep 29, 2026

[Bug]: Non EVM native assets displayed multiple times and on top of each other when switching networks MetaMask/metamask-extension#46721

Open

Kriys94 marked this pull request as ready for review September 30, 2026 07:42

Kriys94 requested review from a team as code owners September 30, 2026 07:42

Kriys94 deployed to default-branch September 30, 2026 07:42 — with GitHub Actions Active