Skip to content

chore: replace tsx with plain Node #10564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mrtenz merged 11 commits into from
Sep 29, 2026
Merged

chore: replace tsx with plain Node #10564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
81a92d1
Replace `tsx` with plain Node
Mrtenz Sep 29, 2026
4d55568
Replace more instances of `tsx`
Mrtenz Sep 29, 2026
016ec46
Fix typo
Mrtenz Sep 29, 2026
2488d7d
Fix get-changed-workspaces script
Mrtenz Sep 29, 2026
a8e1f7e
Add temporary resolver for kyc-controller
Mrtenz Sep 29, 2026
052b72b
Move custom resolver to root
Mrtenz Sep 29, 2026
bcf9108
Revert import changes
Mrtenz Sep 29, 2026
9ca9217
Fix type import
Mrtenz Sep 29, 2026
2fc725f
Fix tests
Mrtenz Sep 29, 2026
2f0ec41
Fix lint error
Mrtenz Sep 29, 2026
20ac37f
Add missing flags
Mrtenz Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/close-stale-release-prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ jobs:
- name: Close inactive release PRs
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: yarn tsx scripts/close-stale-release-prs.ts
run: yarn close-stale-release-prs
2 changes: 1 addition & 1 deletion .github/workflows/lint-build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
if: matrix.node-version == '24.x'
run: |
if [[ -n "$MERGE_BASE" ]]; then
OUTPUT=$(yarn tsx scripts/get-changed-workspaces.ts --merge-base "$MERGE_BASE" --head-ref "$HEAD_SHA")
OUTPUT=$(yarn get-changed-workspaces --merge-base "$MERGE_BASE" --head-ref "$HEAD_SHA")
PACKAGES=$(echo "$OUTPUT" | jq -c '.names')
if [[ $(echo "$OUTPUT" | jq '.hasRootChange') == "true" ]]; then
CHANGED_PATHS="full"
Expand Down
22 changes: 11 additions & 11 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,38 +19,40 @@
"build:docs": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run build:docs",
"build:only-clean": "rimraf -g 'packages/*/dist' 'packages/*/tsconfig.build.tsbuildinfo'",
"build:types": "tsc --build tsconfig.build.json --verbose",
"changelog:merge": "tsx scripts/merge-changelog-conflicts.ts",
"changelog:merge": "node --import ./scripts/resolver/register.ts --experimental-transform-types scripts/merge-changelog-conflicts.ts",
"changelog:update": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run changelog:update",
"changelog:validate": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run changelog:validate",
"codeowners:check": "tsx scripts/manage-codeowners.ts check",
"codeowners:generate": "tsx scripts/manage-codeowners.ts generate",
"create-package": "tsx scripts/create-package",
"close-stale-release-prs": "node --import ./scripts/resolver/register.ts --experimental-transform-types scripts/close-stale-release-prs.ts",
"codeowners:check": "node scripts/manage-codeowners.ts check",
"codeowners:generate": "node scripts/manage-codeowners.ts generate",
"create-package": "node --import ./scripts/resolver/register.ts --experimental-transform-types scripts/create-package/index.ts",
"create-release-branch": "create-release-branch --formatter oxfmt",
"docs:platform-api:build": "yarn workspace @metamask/platform-api-docs cli ../.. --build --project-label Core",
"docs:platform-api:dev": "yarn workspace @metamask/platform-api-docs cli ../.. --dev --project-label Core",
"docs:platform-api:serve": "yarn workspace @metamask/platform-api-docs cli ../.. --serve --project-label Core",
"get-changed-workspaces": "node scripts/get-changed-workspaces.ts",
"lint": "yarn lint:oxlint && echo && yarn lint:misc --check && yarn constraints && yarn lint:dependencies && yarn lint:teams && yarn messenger-action-types:check && yarn readme-content:check && yarn lint:tsconfigs:all && yarn codeowners:check",
"lint:dependencies": "knip --config knip.config.mts --dependencies && yarn dedupe --check",
"lint:dependencies:fix": "knip --config knip.config.mts --dependencies && yarn dedupe",
"lint:fix": "yarn lint:oxlint --fix --prune-suppressions && echo && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies:fix && yarn messenger-action-types:generate && yarn readme-content:update && yarn codeowners:generate",
"lint:misc": "oxfmt --ignore-path .gitignore",
"lint:misc:check": "yarn lint:misc --check",
"lint:oxlint": "oxlint",
"lint:teams": "tsx scripts/lint-teams-json.ts",
"lint:teams": "node --import ./scripts/resolver/register.ts --experimental-transform-types scripts/lint-teams-json.ts",
"lint:tsc": "tsc --build tsconfig.lint.json",
"lint:tsc:clean": "yarn lint:tsc:only-clean && yarn lint:tsc",
"lint:tsc:only-clean": "rimraf -g 'packages/*/.tsc-lint-cache' '.tsc-lint-cache'",
"lint:tsconfigs": "tsx scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs": "node --import ./scripts/resolver/register.ts --experimental-transform-types scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:all": "yarn workspaces foreach --all --parallel --interlaced --verbose run lint:tsconfigs",
"lint:tsconfigs:fix": "tsx scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"lint:tsconfigs:fix": "node --import ./scripts/resolver/register.ts --experimental-transform-types scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"lint:tsconfigs:fix:all": "yarn workspaces foreach --all --parallel --interlaced --verbose run lint:tsconfigs:fix",
"messenger-action-types:check": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run messenger-action-types:check",
"messenger-action-types:generate": "yarn workspaces foreach --all --no-private --parallel --interlaced --verbose run messenger-action-types:generate",
"postinstall": "yarn skills:postinstall",
"prepack": "./scripts/prepack.sh",
"prepare-preview-builds": "./scripts/prepare-preview-builds.sh",
"readme-content:check": "tsx scripts/update-readme-content.ts --check",
"readme-content:update": "tsx scripts/update-readme-content.ts",
"readme-content:check": "node scripts/update-readme-content.ts --check",
"readme-content:update": "node scripts/update-readme-content.ts",
"setup": "yarn install",
"skills": "metamask-skills sync",
"skills:postinstall": "metamask-skills postinstall",
Expand Down Expand Up @@ -106,7 +108,6 @@
"semver": "^7.8.5",
"simple-git-hooks": "^2.14.0",
"ts-jest": "^29.4.14",
"tsx": "^4.23.15",
"typescript": "npm:@typescript/typescript6@^6.0.2",
"uuid": "^11.1.1",
"yargs": "^17.7.3"
Expand All @@ -128,7 +129,6 @@
"@keystonehq/bc-ur-registry-eth>hdkey>secp256k1": true,
"@lavamoat/preinstall-always-fail": false,
"simple-git-hooks": false,
"tsx>esbuild": false,
"jest>@jest/core>jest-resolve>unrs-resolver": false,
"@metamask/network-controller>@metamask/config-registry-controller>@metamask/keyring-controller>ethereumjs-wallet>ethereum-cryptography>keccak": false,
"@metamask/network-controller>@metamask/config-registry-controller>@metamask/keyring-controller>ethereumjs-wallet>ethereum-cryptography>secp256k1": false,
Expand Down
9 changes: 4 additions & 5 deletions packages/account-tree-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
"build:only-clean": "rimraf './dist' './tsconfig.build.tsbuildinfo'",
"changelog:update": "../../scripts/update-changelog.sh @metamask/account-tree-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/account-tree-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"lint:tsconfigs": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",

@Mrtenz Mrtenz Sep 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need --experimental-transform-types because @metamask/utils uses enums. We can remove this if we replace the enums.

@mcmire mcmire Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives us time to migrate utils so I'm okay with it. It's good that once we don't need this we can quickly remove it via yarn.config.cjs too.

"lint:tsconfigs:fix": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
"test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
"test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",
Expand Down Expand Up @@ -76,7 +76,6 @@
"jest": "^30.5.2",
"rimraf": "^6.1.3",
"ts-jest": "^29.4.14",
"tsx": "^4.23.15",
"typedoc": "^0.25.13",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "npm:@typescript/typescript6@^6.0.2",
Expand Down
9 changes: 4 additions & 5 deletions packages/accounts-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
"build:only-clean": "rimraf './dist' './tsconfig.build.tsbuildinfo'",
"changelog:update": "../../scripts/update-changelog.sh @metamask/accounts-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/accounts-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"lint:tsconfigs": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
"test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
"test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",
Expand Down Expand Up @@ -78,7 +78,6 @@
"jest": "^30.5.2",
"rimraf": "^6.1.3",
"ts-jest": "^29.4.14",
"tsx": "^4.23.15",
"typedoc": "^0.25.13",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "npm:@typescript/typescript6@^6.0.2",
Expand Down
9 changes: 4 additions & 5 deletions packages/address-book-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
"build:only-clean": "rimraf './dist' './tsconfig.build.tsbuildinfo'",
"changelog:update": "../../scripts/update-changelog.sh @metamask/address-book-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/address-book-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"lint:tsconfigs": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
"test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
"test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",
Expand All @@ -63,7 +63,6 @@
"jest": "^30.5.2",
"rimraf": "^6.1.3",
"ts-jest": "^29.4.14",
"tsx": "^4.23.15",
"typedoc": "^0.25.13",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "npm:@typescript/typescript6@^6.0.2"
Expand Down
5 changes: 2 additions & 3 deletions packages/advanced-chart-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
"build:only-clean": "rimraf './dist' './tsconfig.build.tsbuildinfo'",
"changelog:update": "../../scripts/update-changelog.sh @metamask/advanced-chart-core",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/advanced-chart-core",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"lint:tsconfigs": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"publish:preview": "yarn npm publish --tag preview",
"since-latest-release": "../../scripts/since-latest-release.sh",
"test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
Expand All @@ -61,7 +61,6 @@
"jest-environment-jsdom": "^30.5.2",
"rimraf": "^6.1.3",
"ts-jest": "^29.4.14",
"tsx": "^4.23.15",
"typedoc": "^0.25.13",
"typescript": "npm:@typescript/typescript6@^6.0.2"
},
Expand Down
9 changes: 4 additions & 5 deletions packages/ai-controllers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
"build:only-clean": "rimraf './dist' './tsconfig.build.tsbuildinfo'",
"changelog:update": "../../scripts/update-changelog.sh @metamask/ai-controllers",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/ai-controllers",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"lint:tsconfigs": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
"test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
"test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",
Expand All @@ -62,7 +62,6 @@
"jest": "^30.5.2",
"rimraf": "^6.1.3",
"ts-jest": "^29.4.14",
"tsx": "^4.23.15",
"typedoc": "^0.25.13",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "npm:@typescript/typescript6@^6.0.2"
Expand Down
9 changes: 4 additions & 5 deletions packages/analytics-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
"build:only-clean": "rimraf './dist' './tsconfig.build.tsbuildinfo'",
"changelog:update": "../../scripts/update-changelog.sh @metamask/analytics-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/analytics-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"lint:tsconfigs": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
"test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
"test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",
Expand All @@ -65,7 +65,6 @@
"jest": "^30.5.2",
"rimraf": "^6.1.3",
"ts-jest": "^29.4.14",
"tsx": "^4.23.15",
"typedoc": "^0.25.13",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "npm:@typescript/typescript6@^6.0.2"
Expand Down
9 changes: 4 additions & 5 deletions packages/analytics-data-regulation-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@
"build:only-clean": "rimraf './dist' './tsconfig.build.tsbuildinfo'",
"changelog:update": "../../scripts/update-changelog.sh @metamask/analytics-data-regulation-controller",
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/analytics-data-regulation-controller",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"lint:tsconfigs": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts",
"lint:tsconfigs:fix": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../scripts/lint-tsconfigs/lint-tsconfigs.ts --fix",
"messenger-action-types:check": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --check",
"messenger-action-types:generate": "node --import ../../scripts/resolver/register.ts --experimental-transform-types ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --esm --generate",
"since-latest-release": "../../scripts/since-latest-release.sh",
"test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
"test:clean": "NODE_OPTIONS=--experimental-vm-modules jest --clearCache",
Expand All @@ -64,7 +64,6 @@
"nock": "^13.5.6",
"rimraf": "^6.1.3",
"ts-jest": "^29.4.14",
"tsx": "^4.23.15",
"typedoc": "^0.25.13",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "npm:@typescript/typescript6@^6.0.2"
Expand Down
Loading
Loading