feat: Add getRandomBytes - #10563
Merged
Merged
feat: Add getRandomBytes#10563
Conversation
Mrtenz
reviewed
Sep 29, 2026
| * @param length - The number of random bytes to generate. | ||
| * @returns An `Uint8Array` of the provided length with random bytes. | ||
| */ | ||
| export function getRandomBytes(length: number): Uint8Array { |
FrederikBolding
enabled auto-merge
September 29, 2026 09:51
Mrtenz
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add utility for generating cryptographically secure random numbers.
References
N/A
Checklist
Note
Low Risk
New additive API with input validation and tests; no changes to existing crypto primitives or consumers.
Overview
Adds
getRandomBytesto@metamask/cryptographyas a small wrapper aroundglobalThis.crypto.getRandomValues, returning aUint8Arrayof the requested size.The function rejects non-positive lengths with a clear error. It is re-exported from the package entrypoint, covered by unit tests (length, CSPRNG call, zero-length throw), and noted in the package changelog under the initial release notes.
Reviewed by Cursor Bugbot for commit 6aa9eed. Bugbot is set up for automated code reviews on this repo. Configure here.