feat: add subscription discountType - #10560
Merged
Merged
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
ejwessel
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add
DiscountType.SUBSCRIPTION('subscription') to the bridge quote fee model so subscription-based MetaBridge discounts can be represented alongside the existingvip,promo, anddaovalues.The quote validator already accepts optional string discount types, so this is an additive typed constant with no changes to quote processing or fee calculations.
References
None.
Test plan
DiscountType.SUBSCRIPTIONChecklist
Note
Low Risk
Additive enum export and tests only; quote validation and fee logic are unchanged.
Overview
Adds
DiscountType.SUBSCRIPTION('subscription') to the exported quote fee enum so clients can recognize subscription-based MetaBridge discounts alongsidevip,promo, anddao.FeeDataSchemastill treatsdiscountTypeas an optional string, so this is a typed constant and changelog entry only—no validator or fee-calculation behavior changes. Tests cover the new enum value inFeeDataSchemaacceptance cases and assert the string value'subscription'.Reviewed by Cursor Bugbot for commit 03b7eb1. Bugbot is set up for automated code reviews on this repo. Configure here.