Repository navigation
fix: match EVM ERC-20 ids case-insensitively in setSelectedToken - #10545
Merged
Merged
Conversation
Catalog rows and callers can differ by EIP-55 checksum case. Exact match stays for Solana, Tron, and Bitcoin, where case is part of the id. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
saustrie-consensys
enabled auto-merge
September 30, 2026 14:41
saustrie-consensys
approved these changes
Sep 30, 2026
roz0n
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RampsController.setSelectedTokenlooked upallTokens, thentopTokens, with an exact CAIP-19 match. A checksummed catalog row and a lowercase caller (the pay controller's mUSD id) missed and threw.eip155:<chain>/erc20:0x…, match case-insensitively and keep the catalog token's ownassetId. Solana, Tron, and Bitcoin still require an exact match.Test plan
yarn workspace @metamask/ramps-controller run jest --no-coverage src/RampsController.test.ts -t setSelectedTokeneip155:143/erc20:0xaca92e…against a checksummed catalog row selects that rowMade with Cursor