refactor: rewrite .js imports in scripts folder to .ts - #10537
Merged
Merged
Conversation
Mrtenz
force-pushed
the
mrtenz/ts-imports
branch
from
September 29, 2026 09:07
1b303af to
ddfd6ac
Compare
Mrtenz
commented
Sep 29, 2026
| * This configuration is extended by all other TypeScript configurations. | ||
| */ | ||
| "compilerOptions": { | ||
| "allowImportingTsExtensions": true, |
Member
Author
There was a problem hiding this comment.
Added this here instead of tsconfig.scripts.json since this is what the IDE uses. If we only add it to tsconfig.scripts.json, you would see a bunch of TypeScript errors in your IDE.
Mrtenz
commented
Sep 29, 2026
| */ | ||
| "extends": "./tsconfig.base.json", | ||
| "compilerOptions": { | ||
| "allowImportingTsExtensions": false, |
Member
Author
There was a problem hiding this comment.
Overriding the new option in tsconfig.base.json.
cryptodev-2s
approved these changes
Sep 29, 2026
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537, where scripts import each other with a .ts extension.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537, where scripts import each other with a .ts extension.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537, where scripts import each other with a .ts extension.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537, where scripts import each other with a .ts extension.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537, where scripts import each other with a .ts extension.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537, where scripts import each other with a .ts extension.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 29, 2026
Follows the convention main adopted in #10537.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 30, 2026
Follows the convention main adopted in #10537, where scripts import each other with a .ts extension.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 30, 2026
Follows the convention main adopted in #10537.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 30, 2026
Follows the convention main adopted in #10537.
cryptodev-2s
added a commit
that referenced
this pull request
Sep 30, 2026
Follows the convention main adopted in #10537.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
In preparation for dropping the
tsxdependency, I've updated all.jsimports to.tsimports in thescriptsfolder. We may eventually want to do this in the packages too, but to keep this pull request small, I skipped that for now.Also updated some scripts from
.mtsto.tsas.mtsis not needed anymore now that the entire workspace is ESM.References
Checklist
Note
Low Risk
Tooling-only refactor in CI scripts and dev configs; runtime product code and package import rules are unchanged.
Overview
Prepares the repo to eventually drop
tsxby standardizing howscripts/is written and invoked.Script entrypoints that used
.mtsare renamed to.ts(e.g.get-changed-workspaces,lint-tsconfigs,close-stale-release-prs, sharedscripts/lib/workspaces). GitHub Actions, rootpackage.json,yarn.config.cjs, and every workspacelint:tsconfigsscript are updated to call the new paths.Relative imports under
scripts/switch from.js/.mjsspecifiers to.ts.tsconfig.base.jsonenablesallowImportingTsExtensions, whiletsconfig.packages.jsonexplicitly turns it off so published packages stay unchanged.oxlint.config.tsadds animport/extensionsoverride forscripts/**/*.ts, and suppression keys are retargeted to the renamed files.Reviewed by Cursor Bugbot for commit ddfd6ac. Bugbot is set up for automated code reviews on this repo. Configure here.