Skip to content

feat: advanced chart core implementation #10521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sahar-fehri merged 2 commits into from
Sep 29, 2026
Merged

feat: advanced chart core implementation #10521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f42934
chore: advanced charts core implementation
sahar-fehri Sep 28, 2026
d518059
chore: advanced charts core implementation
sahar-fehri Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
306 changes: 306 additions & 0 deletions oxlint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,312 @@
"count": 1
}
},
"packages/advanced-chart-core/src/__tests__/index.test.ts": {
Comment thread
sahar-fehri marked this conversation as resolved.
"typescript/no-unnecessary-type-assertion": {
"count": 2
},
"typescript/no-unsafe-assignment": {
"count": 1
}
},
"packages/advanced-chart-core/src/core/__tests__/bootstrap.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 4
},
"typescript/no-unsafe-assignment": {
"count": 1
},
"typescript/unbound-method": {
"count": 1
}
},
"packages/advanced-chart-core/src/core/__tests__/bridge.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 1
},
"typescript/no-unsafe-assignment": {
"count": 1
},
"typescript/unbound-method": {
"count": 1
}
},
"packages/advanced-chart-core/src/core/__tests__/loadLibrary.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 2
}
},
"packages/advanced-chart-core/src/core/__tests__/resolution.test.ts": {
"typescript/no-unsafe-argument": {
"count": 1
}
},
"packages/advanced-chart-core/src/core/__tests__/timezone.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 1
}
},
"packages/advanced-chart-core/src/core/dataLifecycle.ts": {
"no-shadow": {
"count": 2
}
},
"packages/advanced-chart-core/src/core/state.ts": {
"no-shadow": {
"count": 2
}
},
"packages/advanced-chart-core/src/features/indicators/__tests__/indicators.test.ts": {
"typescript/no-unsafe-assignment": {
"count": 1
}
},
"packages/advanced-chart-core/src/features/indicators/__tests__/legend.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 56
},
"typescript/unbound-method": {
"count": 3
}
},
"packages/advanced-chart-core/src/features/indicators/__tests__/subPane.test.ts": {
"typescript/no-unsafe-assignment": {
"count": 2
},
"typescript/no-unsafe-member-access": {
"count": 3
}
},
"packages/advanced-chart-core/src/features/indicators/index.ts": {
"no-shadow": {
"count": 6
},
"unicorn/no-useless-undefined": {
"count": 3
}
},
"packages/advanced-chart-core/src/features/indicators/legend.ts": {
"no-shadow": {
"count": 10
},
"unicorn/no-useless-undefined": {
"count": 1
}
},
"packages/advanced-chart-core/src/features/indicators/studies.ts": {
"no-shadow": {
"count": 3
}
},
"packages/advanced-chart-core/src/features/volume/__tests__/volume.test.ts": {
"typescript/no-unsafe-assignment": {
"count": 1
},
"typescript/no-unsafe-member-access": {
"count": 1
}
},
"packages/advanced-chart-core/src/features/volume/index.ts": {
"unicorn/no-useless-undefined": {
"count": 1
}
},
"packages/advanced-chart-core/src/interaction/__tests__/crosshair.test.ts": {
"id-length": {
"count": 2
},
"no-shadow": {
"count": 2
},
"typescript/no-unsafe-assignment": {
"count": 1
}
},
"packages/advanced-chart-core/src/interaction/__tests__/visibleRange.test.ts": {
"typescript/no-unsafe-assignment": {
"count": 1
}
},
"packages/advanced-chart-core/src/messages/__tests__/handler.test.ts": {
"typescript/no-unsafe-assignment": {
"count": 1
}
},
"packages/advanced-chart-core/src/messages/handler.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 1
}
},
"packages/advanced-chart-core/src/overlays/positionLines/__tests__/positionLines.test.ts": {
"typescript/no-unsafe-assignment": {
"count": 1
},
"typescript/no-unsafe-member-access": {
"count": 4
}
},
"packages/advanced-chart-core/src/overlays/positionLines/__tests__/state.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 5
}
},
"packages/advanced-chart-core/src/overlays/positionLines/index.ts": {
"unicorn/no-useless-undefined": {
"count": 3
}
},
"packages/advanced-chart-core/src/overlays/socialLeaderboard/__tests__/socialLeaderboard.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 2
}
},
"packages/advanced-chart-core/src/overlays/tradeMarkers/__tests__/animation.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 1
}
},
"packages/advanced-chart-core/src/overlays/tradeMarkers/__tests__/markerHitTest.test.ts": {
"no-shadow": {
"count": 2
},
"typescript/no-unnecessary-type-assertion": {
"count": 1
},
"typescript/no-unsafe-assignment": {
"count": 1
}
},
"packages/advanced-chart-core/src/overlays/tradeMarkers/index.ts": {
"no-shadow": {
"count": 1
}
},
"packages/advanced-chart-core/src/pagination/__tests__/priceApi.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 3
},
"typescript/no-unsafe-assignment": {
"count": 1
},
"typescript/no-unsafe-member-access": {
"count": 1
}
},
"packages/advanced-chart-core/src/pagination/__tests__/rnBacked.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 13
},
"typescript/no-unsafe-assignment": {
"count": 18
},
"typescript/no-unsafe-member-access": {
"count": 22
}
},
"packages/advanced-chart-core/src/platform/__tests__/reactNativeHost.test.ts": {
"typescript/no-unsafe-assignment": {
"count": 1
},
"typescript/unbound-method": {
"count": 1
}
},
"packages/advanced-chart-core/src/platform/iframeHost.ts": {
"no-shadow": {
"count": 1
}
},
"packages/advanced-chart-core/src/platform/reactNativeHost.ts": {
"no-shadow": {
"count": 2
}
},
"packages/advanced-chart-core/src/widget/__tests__/chartType.test.ts": {
"typescript/no-unsafe-member-access": {
"count": 1
}
},
"packages/advanced-chart-core/src/widget/__tests__/datafeed.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 11
},
"typescript/no-unsafe-assignment": {
"count": 4
},
"typescript/no-unsafe-member-access": {
"count": 13
}
},
"packages/advanced-chart-core/src/widget/__tests__/externalLinkBridge.test.ts": {
"no-shadow": {
"count": 1
},
"typescript/no-unnecessary-type-assertion": {
"count": 1
},
"typescript/no-unsafe-assignment": {
"count": 1
}
},
"packages/advanced-chart-core/src/widget/__tests__/initChart.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 2
},
"typescript/no-unsafe-assignment": {
"count": 3
},
"typescript/no-unsafe-call": {
"count": 9
},
"typescript/no-unsafe-member-access": {
"count": 18
}
},
"packages/advanced-chart-core/src/widget/__tests__/ohlcvIngestion.test.ts": {
"no-shadow": {
"count": 4
},
"no-unsafe-optional-chaining": {
"count": 5
},
"typescript/no-unsafe-assignment": {
"count": 9
},
"typescript/no-unsafe-call": {
"count": 4
},
"typescript/no-unsafe-member-access": {
"count": 13
}
},
"packages/advanced-chart-core/src/widget/__tests__/scaleLayout.test.ts": {
"typescript/no-unsafe-member-access": {
"count": 10
}
},
"packages/advanced-chart-core/src/widget/__tests__/theme.test.ts": {
"typescript/no-unsafe-assignment": {
"count": 4
},
"typescript/no-unsafe-member-access": {
"count": 11
}
},
"packages/advanced-chart-core/src/widget/__tests__/tvDomHelpers.test.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 1
}
},
"packages/advanced-chart-core/src/widget/datafeed.ts": {
"unicorn/no-useless-undefined": {
"count": 1
}
},
"packages/advanced-chart-core/src/widget/externalLinkBridge.ts": {
"typescript/no-unnecessary-type-assertion": {
"count": 5
}
},
"packages/ai-controllers/jest.config.cjs": {
"import/unambiguous": {
"count": 1
Expand Down
5 changes: 5 additions & 0 deletions oxlint.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ export default createConfig({
},
},

{
files: ['packages/advanced-chart-core/**'],
env: { browser: true },
},

{
files: [
'packages/bitcoin-regtest-up/src/bin/bitcoin-regtest-up.ts',
Expand Down
10 changes: 10 additions & 0 deletions packages/advanced-chart-core/jest.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,14 @@ const displayName = path.basename(__dirname);
module.exports = merge(baseConfig, {
// The display name when running multiple projects
displayName,

// The TradingView Advanced Charts engine is browser/WebView code that relies
// on `window`, `document`, and `requestAnimationFrame`, so its tests run in a
// DOM environment. (Upstream in mobile these were per-file `@jest-environment
// jsdom` docblocks; here it is the package default.)
testEnvironment: 'jsdom',

// Reset the node-oriented `customExportConditions` inherited from the base
// config so jsdom resolves browser export conditions.
testEnvironmentOptions: {},
});
8 changes: 5 additions & 3 deletions packages/advanced-chart-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@
"types": "./dist/index.d.ts",
"default": "./dist/index.js"
},
"./host": {
"types": "./dist/host-entry.d.ts",
"default": "./dist/host-entry.js"
},
"./package.json": "./package.json"
},
"publishConfig": {
Expand All @@ -41,8 +45,6 @@
"changelog:validate": "../../scripts/validate-changelog.sh @metamask/advanced-chart-core",
"lint:tsconfigs": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts",
"lint:tsconfigs:fix": "tsx ../../scripts/lint-tsconfigs/lint-tsconfigs.mts --fix",
"messenger-action-types:check": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --check",
"messenger-action-types:generate": "tsx ../../packages/messenger-cli/src/cli.ts --formatter oxfmt --generate",
"publish:preview": "yarn npm publish --tag preview",
"since-latest-release": "../../scripts/since-latest-release.sh",
"test": "NODE_OPTIONS=--experimental-vm-modules jest --reporters=jest-silent-reporter",
Expand All @@ -56,11 +58,11 @@
"@typescript/native": "npm:typescript@^7.0.2",
"deepmerge": "^4.3.1",
"jest": "^30.4.2",
"jest-environment-jsdom": "^30.4.1",
"rimraf": "^6.1.3",
"ts-jest": "^29.4.14",
"tsx": "^4.23.15",
"typedoc": "^0.25.13",
"typedoc-plugin-missing-exports": "^2.0.0",
"typescript": "npm:@typescript/typescript6@^6.0.2"
},
"engines": {
Expand Down
Loading
Loading