Skip to content

chore: initialize advanced-chart-core package - #10520

Merged
sahar-fehri merged 5 commits into
mainfrom
chore/bootstrap-advanced-chart-core
Sep 28, 2026
Merged

sahar-fehri merged 5 commits into
mainfrom
chore/bootstrap-advanced-chart-core

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

Initialize advanced-chart-core package.

This is scaffolding only — a standard package skeleton with a placeholder greeter export and Jest test. The actual chart engine implementation will follow in a stacked PR.

What this PR does

  • Adds @metamask/advanced-chart-core workspace package (dual MIT/Apache license, changelog, README, build/test/docs scripts)
  • Placeholder greeter named export + test
  • Monorepo wiring:
    • codeowners.ts / CODEOWNERS — ownership assigned to @MetaMask/metamask-assets, @MetaMask/perps, @MetaMask/social-ai
    • teams.json — adds advanced-chart-core entry
    • tsconfig.json / tsconfig.build.json — adds project references
    • README.md — adds package to list and dependency diagram
    • yarn.lock — updated

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
New isolated package skeleton with no changes to existing controllers or client integration paths.

Overview
Adds @metamask/advanced-chart-core as a new workspace package with the usual monorepo scaffolding (dual MIT/Apache licensing, build/test/docs scripts, TypeDoc/Jest config, and an Unreleased changelog aimed at a future TradingView WebView engine).

Runtime code is placeholder only: a greeter export plus a small Jest test; there is no chart engine or host transport in this diff.

Monorepo wiring registers the package in root tsconfig references, README package list and Mermaid graph, yarn.lock, oxlint-suppressions for its Jest config, and ownership via CODEOWNERS, codeowners.ts (@MetaMask/metamask-assets, @MetaMask/perps), and teams.json (team-assets).

Reviewed by Cursor Bugbot for commit a94eaf7. Bugbot is set up for automated code reviews on this repo. Configure here.

@sahar-fehri
sahar-fehri requested a review from a team as a code owner September 28, 2026 13:03
@sahar-fehri
sahar-fehri deployed to default-branch September 28, 2026 13:03 — with GitHub Actions Active
@sahar-fehri
sahar-fehri added this pull request to stack #10522 September 28, 2026 13:28
cryptodev-2s
cryptodev-2s previously approved these changes Sep 28, 2026
@sahar-fehri
sahar-fehri added this pull request to the merge queue Sep 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 28, 2026
@sahar-fehri
sahar-fehri added this pull request to the merge queue Sep 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 28, 2026
@sahar-fehri
sahar-fehri force-pushed the chore/bootstrap-advanced-chart-core branch from 1d7be96 to ae915be Compare September 28, 2026 14:47
@sahar-fehri
sahar-fehri added this pull request to the merge queue Sep 28, 2026
Merged via the queue into main with commit 21a96a6 Sep 28, 2026
342 checks passed
@sahar-fehri
sahar-fehri deleted the chore/bootstrap-advanced-chart-core branch September 28, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants