chore: initialize advanced-chart-core package - #10520
Merged
Merged
Conversation
cryptodev-2s
previously approved these changes
Sep 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 28, 2026
sahar-fehri
force-pushed
the
chore/bootstrap-advanced-chart-core
branch
from
September 28, 2026 14:47
1d7be96 to
ae915be
Compare
cryptodev-2s
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Initialize
advanced-chart-corepackage.This is scaffolding only — a standard package skeleton with a placeholder
greeterexport and Jest test. The actual chart engine implementation will follow in a stacked PR.What this PR does
@metamask/advanced-chart-coreworkspace package (dual MIT/Apache license, changelog, README, build/test/docs scripts)greeternamed export + testcodeowners.ts/CODEOWNERS— ownership assigned to@MetaMask/metamask-assets,@MetaMask/perps,@MetaMask/social-aiteams.json— addsadvanced-chart-coreentrytsconfig.json/tsconfig.build.json— adds project referencesREADME.md— adds package to list and dependency diagramyarn.lock— updatedReferences
Checklist
Note
Low Risk
New isolated package skeleton with no changes to existing controllers or client integration paths.
Overview
Adds
@metamask/advanced-chart-coreas a new workspace package with the usual monorepo scaffolding (dual MIT/Apache licensing, build/test/docs scripts, TypeDoc/Jest config, and an Unreleased changelog aimed at a future TradingView WebView engine).Runtime code is placeholder only: a
greeterexport plus a small Jest test; there is no chart engine or host transport in this diff.Monorepo wiring registers the package in root
tsconfigreferences,READMEpackage list and Mermaid graph,yarn.lock,oxlint-suppressionsfor its Jest config, and ownership viaCODEOWNERS,codeowners.ts(@MetaMask/metamask-assets,@MetaMask/perps), andteams.json(team-assets).Reviewed by Cursor Bugbot for commit a94eaf7. Bugbot is set up for automated code reviews on this repo. Configure here.