Repository navigation
chore: expose structured stx fetch error data - #10494
Merged
Merged
Conversation
rarquevaux
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Problem
The sentinel API returns structured error data for some fetch errors but they get stringified. This requires consumers to parse details from the Error message
Solution
Add the raw JSON data to the Error object so it can be accessed through
error.dataReferences
Fixes https://consensyssoftware.atlassian.net/browse/SWAPS-5090
Checklist
Note
Low Risk
Small change to error shape for failed HTTP fetches; consumers that parsed the old message string need to use
error.datainstead.Overview
When Sentinel API calls fail with a non-OK HTTP response,
handleFetchno longer embeds the full JSON body in the thrownErrormessage. It now throwsFetch error: {status}and attaches the response body (keys camelCased viamapKeysToCamel) onerror.data, so callers can read structured fields without parsing the message string.Unit tests cover success, network failure, and non-OK responses (including the existing
console.logof the response). The package changelog notes this under Unreleased.Reviewed by Cursor Bugbot for commit f9680b8. Bugbot is set up for automated code reviews on this repo. Configure here.