Repository navigation
Release 1285.0.0 - #10423
Release 1285.0.0#10423
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@metamaskbot update-changelogs |
This comment has been minimized.
This comment has been minimized.
|
✅ No changelog changes needed. |
# Conflicts: # package.json
The merge-base changed after approval.
| ), | ||
| ).toStrictEqual(ADDRESS_2_MOCK); | ||
| }); | ||
|
|
There was a problem hiding this comment.
@pedronfigueiredo we don't mix up package changes with releases would you mind extracting into a separate PR merged before ? then update the release or maybe this was a miss handled merge conflicts ?
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [18.0.1] |
There was a problem hiding this comment.
Heads up, we don't log changes to development dependencies in the changelog, only production dependencies. In fact since we are only changing dev dependencies for perps-controller we probably don't need to include in this release. Thoughts on reverting changes to this package?
There was a problem hiding this comment.
Understood, I omitted the perps release and its dev-only changelog entry while keeping workspace dev dependency ranges aligned.
Addressed in d0d2e7a4e8 (commit).
| - **BREAKING:** Update the default `SubscriptionController` instance to `@metamask/subscription-controller@10.0.0`, changing types exposed through `DefaultInstances` and `DefaultState` ([#10305](https://github.com/MetaMask/core/pull/10305), [#10416](https://github.com/MetaMask/core/pull/10416), [#10423](https://github.com/MetaMask/core/pull/10423)) | ||
| - `Subscription.currentPeriodStart`, `currentPeriodEnd`, `cancelType`, and `isEligibleForSupport` are now optional; consumers must handle missing values. `TokenPaymentInfo.isVaultShare` was removed; use `isVaultShareToken` instead. | ||
| - **BREAKING:** Update the default `TransactionController` instance to `@metamask/transaction-controller@72.0.0`, removing approval-time sponsorship and signing hooks from types exposed through `DefaultInstances` ([#10420](https://github.com/MetaMask/core/pull/10420), [#10423](https://github.com/MetaMask/core/pull/10423)) | ||
| - Migrate `isSponsored` and `shouldSign` hooks to `isGasFeeSponsored` and `isExternalSign` transaction metadata. The `hooks` option is required again; pass `hooks: {}` when no hooks are needed. | ||
| - Bump `@metamask/transaction-controller` from `^70.1.0` to `^72.0.0` ([#10386](https://github.com/MetaMask/core/pull/10386), [#10423](https://github.com/MetaMask/core/pull/10423)) | ||
| - Bump `@metamask/keyring-controller` from `^28.0.0` to `^28.1.0` ([#10418](https://github.com/MetaMask/core/pull/10418)) | ||
| - Bump `@metamask/shield-controller` from `^7.0.1` to `^7.0.2` ([#10423](https://github.com/MetaMask/core/pull/10423)) | ||
| - Bump `@metamask/subscription-controller` from `^9.1.0` to `^10.0.0` ([#10423](https://github.com/MetaMask/core/pull/10423)) |
There was a problem hiding this comment.
Nit: Could consolidate these:
| - **BREAKING:** Update the default `SubscriptionController` instance to `@metamask/subscription-controller@10.0.0`, changing types exposed through `DefaultInstances` and `DefaultState` ([#10305](https://github.com/MetaMask/core/pull/10305), [#10416](https://github.com/MetaMask/core/pull/10416), [#10423](https://github.com/MetaMask/core/pull/10423)) | |
| - `Subscription.currentPeriodStart`, `currentPeriodEnd`, `cancelType`, and `isEligibleForSupport` are now optional; consumers must handle missing values. `TokenPaymentInfo.isVaultShare` was removed; use `isVaultShareToken` instead. | |
| - **BREAKING:** Update the default `TransactionController` instance to `@metamask/transaction-controller@72.0.0`, removing approval-time sponsorship and signing hooks from types exposed through `DefaultInstances` ([#10420](https://github.com/MetaMask/core/pull/10420), [#10423](https://github.com/MetaMask/core/pull/10423)) | |
| - Migrate `isSponsored` and `shouldSign` hooks to `isGasFeeSponsored` and `isExternalSign` transaction metadata. The `hooks` option is required again; pass `hooks: {}` when no hooks are needed. | |
| - Bump `@metamask/transaction-controller` from `^70.1.0` to `^72.0.0` ([#10386](https://github.com/MetaMask/core/pull/10386), [#10423](https://github.com/MetaMask/core/pull/10423)) | |
| - Bump `@metamask/keyring-controller` from `^28.0.0` to `^28.1.0` ([#10418](https://github.com/MetaMask/core/pull/10418)) | |
| - Bump `@metamask/shield-controller` from `^7.0.1` to `^7.0.2` ([#10423](https://github.com/MetaMask/core/pull/10423)) | |
| - Bump `@metamask/subscription-controller` from `^9.1.0` to `^10.0.0` ([#10423](https://github.com/MetaMask/core/pull/10423)) | |
| - **BREAKING:** Bump `@metamask/subscription-controller` from `^9.1.0` to `^10.0.0` ([#10423](https://github.com/MetaMask/core/pull/10423)) | |
| - Types exposed through `DefaultInstances` and `DefaultState` are changed: | |
| - `Subscription.currentPeriodStart`, `currentPeriodEnd`, `cancelType`, and `isEligibleForSupport` are now optional; consumers must handle missing values. | |
| - `TokenPaymentInfo.isVaultShare` was removed; use `isVaultShareToken` instead. | |
| - **BREAKING:** Bump `@metamask/transaction-controller` from `^70.1.0` to `^72.0.0` ([#10386](https://github.com/MetaMask/core/pull/10386), [#10423](https://github.com/MetaMask/core/pull/10423)) | |
| - Approval-time sponsorship and signing hooks from types exposed through `DefaultInstances` have been removed: | |
| - Migrate `isSponsored` and `shouldSign` hooks to `isGasFeeSponsored` and `isExternalSign` transaction metadata. The `hooks` option is required again; pass `hooks: {}` when no hooks are needed. | |
| - Bump `@metamask/keyring-controller` from `^28.0.0` to `^28.1.0` ([#10418](https://github.com/MetaMask/core/pull/10418)) | |
| - Bump `@metamask/shield-controller` from `^7.0.1` to `^7.0.2` ([#10423](https://github.com/MetaMask/core/pull/10423)) |
There was a problem hiding this comment.
Consolidated the two breaking dependency bumps and their migration guidance, removing the duplicate bump entries.
Addressed in 860bd8f5bb (commit).
cryptodev-2s
left a comment
There was a problem hiding this comment.
One last suggestion then we are good
| ## [18.0.1] | ||
|
|
||
| ### Changed | ||
|
|
||
| - Update development dependencies on `@metamask/transaction-controller` to `^72.0.0` and `@metamask/subscription-controller` to `^10.0.0` ([#10423](https://github.com/MetaMask/core/pull/10423)) | ||
|
|
There was a problem hiding this comment.
No need for this as used only as a dev dependency
| ## [18.0.1] | |
| ### Changed | |
| - Update development dependencies on `@metamask/transaction-controller` to `^72.0.0` and `@metamask/subscription-controller` to `^10.0.0` ([#10423](https://github.com/MetaMask/core/pull/10423)) |
There was a problem hiding this comment.
Removed the dev-only changelog entry and omitted the perps release.
Addressed in d0d2e7a4e8 (commit).
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/perps-controller@18.0.1...HEAD | ||
| [18.0.1]: https://github.com/MetaMask/core/compare/@metamask/perps-controller@18.0.0...@metamask/perps-controller@18.0.1 |
There was a problem hiding this comment.
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/perps-controller@18.0.1...HEAD | |
| [18.0.1]: https://github.com/MetaMask/core/compare/@metamask/perps-controller@18.0.0...@metamask/perps-controller@18.0.1 | |
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/perps-controller@18.0.0...HEAD |
There was a problem hiding this comment.
Restored the Unreleased comparison link to perps-controller@18.0.0.
Addressed in d0d2e7a4e8 (commit).
There was a problem hiding this comment.
Follow-up: with the patch bump, the new release section is 18.0.1 and the Unreleased comparison now starts at 18.0.1.
Updated in 6017d49616 (commit).
| { | ||
| "name": "@metamask/perps-controller", | ||
| "version": "18.0.0", | ||
| "version": "18.0.1", |
There was a problem hiding this comment.
| "version": "18.0.1", | |
| "version": "18.0.0", |
There was a problem hiding this comment.
Restored the perps-controller package version to 18.0.0.
Addressed in d0d2e7a4e8 (commit).
|
I was contacted by @aganglada and included a release of the perps controller as well. #10429 |
Explanation
Prepare monorepo release 1285.0.0 for
@metamask/transaction-controller@72.0.0and all 19 direct workspace dependents.perps-controlleris now included for the consumer-facing HIP-3 snapshot fix merged in #10429, not merely for its development dependencies;earn-controlleralso has an existing production dependency bump. This branch incorporates currentmain, including #10429 and #10419. No source-code changes are introduced by this PR relative to currentmain.Versions in this release
transaction-controllersubscription-controllerwallettransaction-pay-controllerassets-controllerassets-controllersbridge-controllerbridge-status-controllerclient-utilsearn-controlleraccount-tree-controllerbump; transaction-controller is dev-only hereeip-5792-middlewaregator-permissions-controllermoney-account-utilsnetwork-enablement-controllerperps-controllerphishing-controllerprofile-metrics-controllershield-controllersmart-transactions-controlleruser-operation-controllerDependent packages have their Unreleased changelog entries moved to their new release sections. Additional non-released transitive dependents receive compatible workspace ranges (
money-account-upgrade-controller,network-connection-banner-controller,signature-controller, and unpublishedwallet-cli); the three published packages receive Unreleased dependency changelog entries.yarn.lockis synchronized. Changes toperps-controller's development dependencies are intentionally omitted from its changelog.Coordination before merge: The transaction-controller hook revert and the subscription-controller's existing breaking type changes affect consumers. Confirm Extension and Mobile migrations before publishing these three major versions. This is a release candidate, not a published release.
References
Validation
yarn buildyarn workspace @metamask/transaction-controller run testyarn workspace @metamask/subscription-controller run testyarn workspace @metamask/transaction-pay-controller run testyarn workspace @metamask/wallet run testyarn workspace @metamask/perps-controller run test(after incorporating fix(perps-controller): accept Hyperliquid provider on HIP-3 snapshot markets #10429)yarn changelog:validate,yarn constraints,yarn install --immutable,yarn dedupe --checkyarn lint:dependencies(after removing stale generated bridge-controllerdistoutput)git diff --checkChecklist
Note
High Risk
Publishes breaking majors for transaction signing/sponsorship and subscription types that require coordinated Extension/Mobile migrations before consumers upgrade
@metamask/walletor@metamask/transaction-controller.Overview
Prepares monorepo release 1285.0.0 by bumping package versions, moving Unreleased changelog notes into release sections, aligning workspace dependency ranges, and refreshing
yarn.lock. There are no application source edits in this diff—only release metadata for work already onmain.The release centers on
@metamask/transaction-controller@72.0.0, which reverts the approval-timeisSponsored/shouldSignhooks in favor of metadata-drivenisGasFeeSponsoredandisExternalSign, drops related exports andisGasFeeSponsoredAvailable, and again requires ahooksobject (usehooks: {}when empty).@metamask/subscription-controller@10.0.0ships existing breaking subscription/payment-token type changes (optional period fields, vault-share detection viaisVaultShareToken, crypto payment failure types).@metamask/wallet@15.0.0bumps those majors plus related dependents.Nineteen direct workspace dependents get compatible semver bumps (mostly patch dependency realignments to
@metamask/transaction-controller@^72.0.0). Notable published notes include@metamask/perps-controller@18.0.1(HIP-3 Terminal snapshot validation fix) and@metamask/transaction-pay-controller@29.2.0(server pay-strategy quoting/submit fixes). Unpublished/transitive packages (wallet-cli,money-account-upgrade-controller, etc.) get range updates without always cutting new versions.Reviewed by Cursor Bugbot for commit 6017d49. Bugbot is set up for automated code reviews on this repo. Configure here.