Skip to content

Release 1285.0.0 - #10423

Merged
pedronfigueiredo merged 17 commits into
mainfrom
release/1285.0.0
Sep 24, 2026
Merged

pedronfigueiredo merged 17 commits into
mainfrom
release/1285.0.0

Conversation

@pedronfigueiredo

@pedronfigueiredo pedronfigueiredo commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

Prepare monorepo release 1285.0.0 for @metamask/transaction-controller@72.0.0 and all 19 direct workspace dependents. perps-controller is now included for the consumer-facing HIP-3 snapshot fix merged in #10429, not merely for its development dependencies; earn-controller also has an existing production dependency bump. This branch incorporates current main, including #10429 and #10419. No source-code changes are introduced by this PR relative to current main.

Versions in this release

Package Version Rationale
transaction-controller 72.0.0 Breaking revert of approval-time sponsorship/signing hooks (#10420)
subscription-controller 10.0.0 Existing Unreleased breaking subscription type changes (#10305, #10416)
wallet 15.0.0 Its exported default instance/state types expose the breaking subscription and transaction-controller changes
transaction-pay-controller 29.2.0 Additional supported pay-strategy flows and server-quote behavior (#10342)
assets-controller 16.1.1 Dependency updates and previously merged fixes
assets-controllers 112.0.3 Dependency updates
bridge-controller 81.3.1 Dependency updates
bridge-status-controller 76.3.1 Dependency updates
client-utils 3.0.3 Dependency update
earn-controller 13.0.1 Existing production account-tree-controller bump; transaction-controller is dev-only here
eip-5792-middleware 4.0.1 Dependency updates
gator-permissions-controller 6.0.1 Dependency updates
money-account-utils 2.0.1 Dependency updates
network-enablement-controller 7.0.1 Dependency updates
perps-controller 18.0.1 Fix Terminal v3 HIP-3 snapshot validation (#10429); patch bump
phishing-controller 18.1.1 Dependency update
profile-metrics-controller 5.1.1 Dependency updates
shield-controller 7.0.2 Dependency updates
smart-transactions-controller 27.0.2 Dependency updates
user-operation-controller 42.0.1 Dependency updates

Dependent packages have their Unreleased changelog entries moved to their new release sections. Additional non-released transitive dependents receive compatible workspace ranges (money-account-upgrade-controller, network-connection-banner-controller, signature-controller, and unpublished wallet-cli); the three published packages receive Unreleased dependency changelog entries. yarn.lock is synchronized. Changes to perps-controller's development dependencies are intentionally omitted from its changelog.

Coordination before merge: The transaction-controller hook revert and the subscription-controller's existing breaking type changes affect consumers. Confirm Extension and Mobile migrations before publishing these three major versions. This is a release candidate, not a published release.

References

Validation

  • yarn build
  • yarn workspace @metamask/transaction-controller run test
  • yarn workspace @metamask/subscription-controller run test
  • yarn workspace @metamask/transaction-pay-controller run test
  • yarn workspace @metamask/wallet run test
  • yarn workspace @metamask/perps-controller run test (after incorporating fix(perps-controller): accept Hyperliquid provider on HIP-3 snapshot markets #10429)
  • yarn changelog:validate, yarn constraints, yarn install --immutable, yarn dedupe --check
  • yarn lint:dependencies (after removing stale generated bridge-controller dist output)
  • git diff --check

Checklist


Note

High Risk
Publishes breaking majors for transaction signing/sponsorship and subscription types that require coordinated Extension/Mobile migrations before consumers upgrade @metamask/wallet or @metamask/transaction-controller.

Overview
Prepares monorepo release 1285.0.0 by bumping package versions, moving Unreleased changelog notes into release sections, aligning workspace dependency ranges, and refreshing yarn.lock. There are no application source edits in this diff—only release metadata for work already on main.

The release centers on @metamask/transaction-controller@72.0.0, which reverts the approval-time isSponsored / shouldSign hooks in favor of metadata-driven isGasFeeSponsored and isExternalSign, drops related exports and isGasFeeSponsoredAvailable, and again requires a hooks object (use hooks: {} when empty). @metamask/subscription-controller@10.0.0 ships existing breaking subscription/payment-token type changes (optional period fields, vault-share detection via isVaultShareToken, crypto payment failure types). @metamask/wallet@15.0.0 bumps those majors plus related dependents.

Nineteen direct workspace dependents get compatible semver bumps (mostly patch dependency realignments to @metamask/transaction-controller@^72.0.0). Notable published notes include @metamask/perps-controller@18.0.1 (HIP-3 Terminal snapshot validation fix) and @metamask/transaction-pay-controller@29.2.0 (server pay-strategy quoting/submit fixes). Unpublished/transitive packages (wallet-cli, money-account-upgrade-controller, etc.) get range updates without always cutting new versions.

Reviewed by Cursor Bugbot for commit 6017d49. Bugbot is set up for automated code reviews on this repo. Configure here.

@pedronfigueiredo pedronfigueiredo added the release:keep-open Prevent auto-close of inactive release/* PRs (3h) label Sep 24, 2026
@pedronfigueiredo

Copy link
Copy Markdown
Contributor Author

@metamaskbot update-changelogs

@metamask-ci

This comment has been minimized.

@pedronfigueiredo
pedronfigueiredo marked this pull request as ready for review September 24, 2026 10:26
@pedronfigueiredo
pedronfigueiredo requested review from a team as code owners September 24, 2026 10:26
OGPoyraz
OGPoyraz previously approved these changes Sep 24, 2026
@metamask-ci

metamask-ci Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

✅ No changelog changes needed.

@pedronfigueiredo
pedronfigueiredo dismissed OGPoyraz’s stale review September 24, 2026 10:31

The merge-base changed after approval.

),
).toStrictEqual(ADDRESS_2_MOCK);
});

@cryptodev-2s cryptodev-2s Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedronfigueiredo we don't mix up package changes with releases would you mind extracting into a separate PR merged before ? then update the release or maybe this was a miss handled merge conflicts ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@pedronfigueiredo pedronfigueiredo changed the title Release/1285.0.0 (transaction-controller 72.0.0) Release/1285.0.0 (transaction-controller and dependents) Sep 24, 2026

## [Unreleased]

## [18.0.1]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up, we don't log changes to development dependencies in the changelog, only production dependencies. In fact since we are only changing dev dependencies for perps-controller we probably don't need to include in this release. Thoughts on reverting changes to this package?

@pedronfigueiredo pedronfigueiredo Sep 24, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, I omitted the perps release and its dev-only changelog entry while keeping workspace dev dependency ranges aligned.

Addressed in d0d2e7a4e8 (commit).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: #10429 merged after this review and adds a consumer-facing HIP-3 fix. At the request of the release author, perps is now included for that fix; its dev-dependency changes remain undocumented.

Updated in a9246da4cc (commit).

Comment thread packages/wallet/CHANGELOG.md Outdated
Comment on lines +14 to +21
- **BREAKING:** Update the default `SubscriptionController` instance to `@metamask/subscription-controller@10.0.0`, changing types exposed through `DefaultInstances` and `DefaultState` ([#10305](https://github.com/MetaMask/core/pull/10305), [#10416](https://github.com/MetaMask/core/pull/10416), [#10423](https://github.com/MetaMask/core/pull/10423))
- `Subscription.currentPeriodStart`, `currentPeriodEnd`, `cancelType`, and `isEligibleForSupport` are now optional; consumers must handle missing values. `TokenPaymentInfo.isVaultShare` was removed; use `isVaultShareToken` instead.
- **BREAKING:** Update the default `TransactionController` instance to `@metamask/transaction-controller@72.0.0`, removing approval-time sponsorship and signing hooks from types exposed through `DefaultInstances` ([#10420](https://github.com/MetaMask/core/pull/10420), [#10423](https://github.com/MetaMask/core/pull/10423))
- Migrate `isSponsored` and `shouldSign` hooks to `isGasFeeSponsored` and `isExternalSign` transaction metadata. The `hooks` option is required again; pass `hooks: {}` when no hooks are needed.
- Bump `@metamask/transaction-controller` from `^70.1.0` to `^72.0.0` ([#10386](https://github.com/MetaMask/core/pull/10386), [#10423](https://github.com/MetaMask/core/pull/10423))
- Bump `@metamask/keyring-controller` from `^28.0.0` to `^28.1.0` ([#10418](https://github.com/MetaMask/core/pull/10418))
- Bump `@metamask/shield-controller` from `^7.0.1` to `^7.0.2` ([#10423](https://github.com/MetaMask/core/pull/10423))
- Bump `@metamask/subscription-controller` from `^9.1.0` to `^10.0.0` ([#10423](https://github.com/MetaMask/core/pull/10423))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could consolidate these:

Suggested change
- **BREAKING:** Update the default `SubscriptionController` instance to `@metamask/subscription-controller@10.0.0`, changing types exposed through `DefaultInstances` and `DefaultState` ([#10305](https://github.com/MetaMask/core/pull/10305), [#10416](https://github.com/MetaMask/core/pull/10416), [#10423](https://github.com/MetaMask/core/pull/10423))
- `Subscription.currentPeriodStart`, `currentPeriodEnd`, `cancelType`, and `isEligibleForSupport` are now optional; consumers must handle missing values. `TokenPaymentInfo.isVaultShare` was removed; use `isVaultShareToken` instead.
- **BREAKING:** Update the default `TransactionController` instance to `@metamask/transaction-controller@72.0.0`, removing approval-time sponsorship and signing hooks from types exposed through `DefaultInstances` ([#10420](https://github.com/MetaMask/core/pull/10420), [#10423](https://github.com/MetaMask/core/pull/10423))
- Migrate `isSponsored` and `shouldSign` hooks to `isGasFeeSponsored` and `isExternalSign` transaction metadata. The `hooks` option is required again; pass `hooks: {}` when no hooks are needed.
- Bump `@metamask/transaction-controller` from `^70.1.0` to `^72.0.0` ([#10386](https://github.com/MetaMask/core/pull/10386), [#10423](https://github.com/MetaMask/core/pull/10423))
- Bump `@metamask/keyring-controller` from `^28.0.0` to `^28.1.0` ([#10418](https://github.com/MetaMask/core/pull/10418))
- Bump `@metamask/shield-controller` from `^7.0.1` to `^7.0.2` ([#10423](https://github.com/MetaMask/core/pull/10423))
- Bump `@metamask/subscription-controller` from `^9.1.0` to `^10.0.0` ([#10423](https://github.com/MetaMask/core/pull/10423))
- **BREAKING:** Bump `@metamask/subscription-controller` from `^9.1.0` to `^10.0.0` ([#10423](https://github.com/MetaMask/core/pull/10423))
- Types exposed through `DefaultInstances` and `DefaultState` are changed:
- `Subscription.currentPeriodStart`, `currentPeriodEnd`, `cancelType`, and `isEligibleForSupport` are now optional; consumers must handle missing values.
- `TokenPaymentInfo.isVaultShare` was removed; use `isVaultShareToken` instead.
- **BREAKING:** Bump `@metamask/transaction-controller` from `^70.1.0` to `^72.0.0` ([#10386](https://github.com/MetaMask/core/pull/10386), [#10423](https://github.com/MetaMask/core/pull/10423))
- Approval-time sponsorship and signing hooks from types exposed through `DefaultInstances` have been removed:
- Migrate `isSponsored` and `shouldSign` hooks to `isGasFeeSponsored` and `isExternalSign` transaction metadata. The `hooks` option is required again; pass `hooks: {}` when no hooks are needed.
- Bump `@metamask/keyring-controller` from `^28.0.0` to `^28.1.0` ([#10418](https://github.com/MetaMask/core/pull/10418))
- Bump `@metamask/shield-controller` from `^7.0.1` to `^7.0.2` ([#10423](https://github.com/MetaMask/core/pull/10423))

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consolidated the two breaking dependency bumps and their migration guidance, removing the duplicate bump entries.

Addressed in 860bd8f5bb (commit).

@mcmire mcmire changed the title Release/1285.0.0 (transaction-controller and dependents) Release 1285.0.0 Sep 24, 2026

@cryptodev-2s cryptodev-2s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last suggestion then we are good

Comment on lines +10 to +15
## [18.0.1]

### Changed

- Update development dependencies on `@metamask/transaction-controller` to `^72.0.0` and `@metamask/subscription-controller` to `^10.0.0` ([#10423](https://github.com/MetaMask/core/pull/10423))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this as used only as a dev dependency

Suggested change
## [18.0.1]
### Changed
- Update development dependencies on `@metamask/transaction-controller` to `^72.0.0` and `@metamask/subscription-controller` to `^10.0.0` ([#10423](https://github.com/MetaMask/core/pull/10423))

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the dev-only changelog entry and omitted the perps release.

Addressed in d0d2e7a4e8 (commit).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: this dev-only changelog entry remains removed. The new release section documents only the consumer-facing fix from #10429, merged since the earlier review.

Updated in a9246da4cc (commit).

Comment on lines +1020 to +1021
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/perps-controller@18.0.1...HEAD
[18.0.1]: https://github.com/MetaMask/core/compare/@metamask/perps-controller@18.0.0...@metamask/perps-controller@18.0.1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/perps-controller@18.0.1...HEAD
[18.0.1]: https://github.com/MetaMask/core/compare/@metamask/perps-controller@18.0.0...@metamask/perps-controller@18.0.1
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/perps-controller@18.0.0...HEAD

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored the Unreleased comparison link to perps-controller@18.0.0.

Addressed in d0d2e7a4e8 (commit).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: #10429 has now merged, so the perps release has an 18.1.0 section for its fix and the Unreleased comparison starts at 18.1.0.

Updated in a9246da4cc (commit).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up: with the patch bump, the new release section is 18.0.1 and the Unreleased comparison now starts at 18.0.1.

Updated in 6017d49616 (commit).

{
"name": "@metamask/perps-controller",
"version": "18.0.0",
"version": "18.0.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "18.0.1",
"version": "18.0.0",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored the perps-controller package version to 18.0.0.

Addressed in d0d2e7a4e8 (commit).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: #10429 has now merged and perps is being released for its consumer-facing fix. The version is 18.1.0 as requested for this release.

Updated in a9246da4cc (commit).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up: the release author opted for a patch bump for the #10429 fix. The perps version is now 18.0.1, not 18.1.0.

Updated in 6017d49616 (commit).

@pedronfigueiredo

Copy link
Copy Markdown
Contributor Author

I was contacted by @aganglada and included a release of the perps controller as well. #10429

@pedronfigueiredo
pedronfigueiredo added this pull request to the merge queue Sep 24, 2026
Merged via the queue into main with commit 054f313 Sep 24, 2026
112 checks passed
@pedronfigueiredo
pedronfigueiredo deleted the release/1285.0.0 branch September 24, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:keep-open Prevent auto-close of inactive release/* PRs (3h)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants