Repository navigation
chore: add KeyringController entropy ID selectors - #10284
Merged
Merged
Conversation
Add selectors to the `keyring-controller` package for getting entropy source IDs. This is a refactor, these selectors were previously written as part of the `profile-sync-controller` package, but they belong with the keyring package.
Gudahtt
force-pushed
the
refactor-keyring-hd-keyring-selectors
branch
from
September 17, 2026 17:02
8132ef5 to
9c31e5c
Compare
Gudahtt
marked this pull request as ready for review
September 17, 2026 17:55
hmalik88
approved these changes
Sep 17, 2026
pull Bot
pushed a commit
to Reality2byte/core
that referenced
this pull request
Sep 24, 2026
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Changes are release versioning and dependency propagation only; risk is mainly that many packages now require keyring-controller 28.1.0 at install time. > > **Overview** > This PR cuts **monorepo release 1283.0.0** and rolls dependency versions through the workspace. > > It finalizes **`@metamask/keyring-controller` 28.1.0** (changelog documents **entropy ID selectors** from [MetaMask#10284](MetaMask#10284)) and **`@metamask/profile-sync-controller` 32.3.1**, then updates **dozens of packages** to depend on `^28.1.0` and/or `^32.3.1`, with matching **CHANGELOG** entries and an updated **`yarn.lock`**. > > There is **no new controller/source logic** in this diff—only version, dependency, and release notes alignment so consumers pick up the new keyring and profile-sync releases together. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 67a5605. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add selectors to the
keyring-controllerpackage for getting entropy source IDs. This is a refactor, these selectors were previously written as part of theprofile-sync-controllerpackage, but they belong with the keyring package.References
N/A
Checklist
Note
Medium Risk
Changes how multi-SRP entropy IDs are resolved for auth and encrypted user storage, though behavior should match the prior HD keyring filtering;
getPrimaryHdKeyringEntropySourceId’s parameter type changed for any external callers.Overview
Moves HD keyring entropy source ID derivation from
profile-sync-controllerinto@metamask/keyring-controller, exportingselectHdKeyringEntropySourceIdsandselectPrimaryHdKeyringEntropySourceId(with unit tests) from the package public API.AuthenticationController and UserStorageController now call those selectors on full
KeyringController:getStateinstead of filtering keyrings locally. The profile-sync helpergetPrimaryHdKeyringEntropySourceIdis narrowed to a throw-on-missing wrapper around the primary selector and now takesKeyringControllerStaterather than a keyrings array;getHdKeyringEntropySourceIdsis removed from shared utils.Reviewed by Cursor Bugbot for commit 9c31e5c. Bugbot is set up for automated code reviews on this repo. Configure here.