Repository navigation
feat(transaction-pay-controller): atomic quoting for subsidized max Money Account deposits #10224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
103ddbe
feat(transaction-pay-controller): atomic quoting for subsidized max M…
OGPoyraz b5837e3
style(transaction-pay-controller): fix formatting
OGPoyraz 5747aa9
test(transaction-pay-controller): cover atomic promotion guards and s…
OGPoyraz b4296ef
docs(transaction-pay-controller): reference PR in changelog
OGPoyraz e81860e
Fix changelog
OGPoyraz ada5102
feat(transaction-pay-controller): address review feedback on atomic m…
OGPoyraz 6616ef8
Merge remote-tracking branch 'origin/main' into ogp/CONF-1949
OGPoyraz 793fe59
refactor(transaction-pay-controller): remove non-max atomic demote path
OGPoyraz aeb9751
Merge remote-tracking branch 'origin/main' into ogp/CONF-1949
OGPoyraz aa57e3d
refactor(transaction-pay-controller): drop discovery target shape check
OGPoyraz 55ba79f
feat(transaction-pay-controller): honor atomic hints for max quotes
OGPoyraz 8a5459d
docs(transaction-pay-controller): describe atomic max hint handling
OGPoyraz d50b3de
fix(transaction-pay-controller): derive max output from source budget
OGPoyraz d43f7b9
docs(transaction-pay-controller): clarify max discovery requirement
OGPoyraz 82988d3
fix(transaction-pay-controller): quote atomic max from source budget
OGPoyraz b8081a9
fix(transaction-pay-controller): use standard quote error fallback
OGPoyraz b1c62ee
docs(transaction-pay-controller): clarify atomic max subsidy hints
OGPoyraz d3f9964
Merge origin/main into ogp/CONF-1949
OGPoyraz 5fd8ff1
Merge branch 'main' into ogp/CONF-1949
OGPoyraz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale txParams in atomic max quotes
High Severity
Atomic max preparation rewrites nested calldata and
requiredAssetson a clone, but leavestxParamson the pre-max deposit amount. Quote-timegetDelegationTransactionand later execute validation still read that staletxParams, so the embedded vault call can lock the original amount while the paired transfer uses the source-budget size.Additional Locations (2)
packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts#L556-L560packages/transaction-pay-controller/src/strategy/relay/relay-quotes.ts#L164-L176Reviewed by Cursor Bugbot for commit 5fd8ff1. Configure here.