Skip to content

feat(transaction-controller): add approval-time sponsorship/signing hooks #10109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedronfigueiredo merged 4 commits into from
Sep 22, 2026
Merged

feat(transaction-controller): add approval-time sponsorship/signing hooks #10109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13d306b
feat(transaction-controller): add approval policy hooks
pedronfigueiredo Sep 22, 2026
6a01c77
fix: defer unsigned publishing to hook
pedronfigueiredo Sep 21, 2026
6a79b81
refactor: extract approval preparation
pedronfigueiredo Sep 21, 2026
71e88f2
fix: clarify unsigned publish error
pedronfigueiredo Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/transaction-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Add `membershipSubscription` transaction type ([#10340](https://github.com/MetaMask/core/pull/10340))

### Changed

- **BREAKING:** Move sponsorship and signing decisions to optional approval-time `isSponsored` and `shouldSign` hooks ([#10109](https://github.com/MetaMask/core/pull/10109))
- The hooks default to non-sponsored and local signing when omitted. Sponsored transactions skip the `shouldSign` hook and local signing, while transactions that skip local signing retain an existing nonce and require a publish hook.
- `isGasFeeSponsored` and `isExternalSign` remain in the public types as deprecated compatibility properties but no longer control the transaction lifecycle; `isGasFeeSponsored` remains available as migration metadata.
- Add `TransactionMeta.isGasFeeSponsoredAvailable` and refresh it during approval preparation when simulation is enabled so sponsorship hooks receive current availability without overriding simulation preferences.

## [70.1.0]

### Changed
Expand Down
Loading
Loading